-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
route53_health_check - add support for CALCULATED type #1631
route53_health_check - add support for CALCULATED type #1631
Conversation
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 4m 53s |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 22s |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 20s |
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 27s |
tests/integration/targets/route53_health_check/tasks/calculate_health_check.yml
Show resolved
Hide resolved
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 09s |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 51s |
changelogs/fragments/1631-route53_health_check-added-calculcated.yml
Outdated
Show resolved
Hide resolved
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 05s |
373f7fa
to
2be7d8b
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 57s |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 27s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple small things, but otherwise looks pretty good.
tests/integration/targets/route53_health_check/tasks/calculate_health_check.yml
Outdated
Show resolved
Hide resolved
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 39s |
64ff7ed
to
0df7e03
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 15s |
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 3m 45s |
…ed.yml Co-authored-by: Alina Buzachis <abuzachis@redhat.com>
…ould be different
79c541d
to
53f813d
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 28s |
regate |
Build failed (gate pipeline). For information on how to proceed, see https://ansible.softwarefactory-project.io/zuul/buildset/952f9a86b8b04c17abe28a744cecfb65 ✔️ ansible-galaxy-importer SUCCESS in 4m 24s |
regate |
625777a
into
ansible-collections:main
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #1682 🤖 @patchback |
route53_health_check - add support for CALCULATED type SUMMARY Fixes #1442 ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/route53_health_check.py ADDITIONAL INFORMATION Reviewed-by: Helen Bailey <hebailey@redhat.com> Reviewed-by: Taeho Park Reviewed-by: Alina Buzachis Reviewed-by: Mike Graves <mgraves@redhat.com> (cherry picked from commit 625777a)
[PR #1631/625777a1 backport][stable-6] route53_health_check - add support for CALCULATED type This is a backport of PR #1631 as merged into main (625777a). SUMMARY Fixes #1442 ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/route53_health_check.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis
…ctions#1631) route53_health_check - add support for CALCULATED type SUMMARY Fixes ansible-collections#1442 ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/route53_health_check.py ADDITIONAL INFORMATION Reviewed-by: Helen Bailey <hebailey@redhat.com> Reviewed-by: Taeho Park Reviewed-by: Alina Buzachis Reviewed-by: Mike Graves <mgraves@redhat.com>
SUMMARY
Fixes #1442
ISSUE TYPE
COMPONENT NAME
plugins/modules/route53_health_check.py
ADDITIONAL INFORMATION