route53_health_check - add support for CALCULATED type #1631

taehopark32 · 2023-06-28T20:12:14Z

SUMMARY

Fixes #1442

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

plugins/modules/route53_health_check.py

ADDITIONAL INFORMATION

softwarefactory-project-zuul · 2023-06-28T20:33:51Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/3dba366bc1054e24ae596aa38ffd8979

✔️ ansible-galaxy-importer SUCCESS in 4m 53s
✔️ build-ansible-collection SUCCESS in 12m 57s
✔️ ansible-test-splitter SUCCESS in 4m 58s
❌ integration-amazon.aws-1 FAILURE in 7m 22s
Skipped 43 jobs

softwarefactory-project-zuul · 2023-06-28T22:28:32Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/013f8b8c5a7245f69b813e0a5b4673c1

✔️ ansible-galaxy-importer SUCCESS in 4m 22s
✔️ build-ansible-collection SUCCESS in 14m 01s
✔️ ansible-test-splitter SUCCESS in 6m 49s
✔️ integration-amazon.aws-1 SUCCESS in 8m 14s
✔️ integration-community.aws-1 SUCCESS in 55m 12s
✔️ integration-community.aws-2 SUCCESS in 17m 08s
Skipped 41 jobs

softwarefactory-project-zuul · 2023-06-29T15:17:04Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/aba6019bcc994376ae54ce0b8e188682

✔️ ansible-galaxy-importer SUCCESS in 4m 20s
✔️ build-ansible-collection SUCCESS in 13m 52s
✔️ ansible-test-splitter SUCCESS in 4m 55s
✔️ integration-amazon.aws-1 SUCCESS in 11m 20s
✔️ integration-community.aws-1 SUCCESS in 40m 19s
✔️ integration-community.aws-2 SUCCESS in 25m 03s
✔️ integration-community.aws-3 SUCCESS in 20m 13s
✔️ integration-community.aws-4 SUCCESS in 8m 43s
✔️ integration-community.aws-5 SUCCESS in 10m 25s
✔️ integration-community.aws-6 SUCCESS in 9m 26s
✔️ integration-community.aws-7 SUCCESS in 8m 47s
✔️ integration-community.aws-8 SUCCESS in 10m 21s
✔️ integration-community.aws-9 SUCCESS in 9m 08s
Skipped 34 jobs

github-actions · 2023-06-29T16:25:06Z

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

softwarefactory-project-zuul · 2023-06-29T20:14:37Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/768e0b28c9c54e6787cb8219d365690f

✔️ ansible-galaxy-importer SUCCESS in 4m 27s
✔️ build-ansible-collection SUCCESS in 12m 45s
✔️ ansible-test-splitter SUCCESS in 4m 36s
✔️ integration-amazon.aws-1 SUCCESS in 9m 50s
Skipped 43 jobs

tests/integration/targets/route53_health_check/tasks/calculate_health_check.yml

plugins/modules/route53_health_check.py

softwarefactory-project-zuul · 2023-07-03T18:42:09Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/a963cee9306d4f6887d109589abc24d9

✔️ ansible-galaxy-importer SUCCESS in 4m 09s
✔️ build-ansible-collection SUCCESS in 13m 17s
✔️ ansible-test-splitter SUCCESS in 5m 16s
✔️ integration-amazon.aws-1 SUCCESS in 9m 45s
Skipped 43 jobs

softwarefactory-project-zuul · 2023-07-03T19:43:04Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/48336ce589de49c7bffbaaaca68216de

✔️ ansible-galaxy-importer SUCCESS in 3m 51s
✔️ build-ansible-collection SUCCESS in 13m 47s
✔️ ansible-test-splitter SUCCESS in 4m 43s
✔️ integration-amazon.aws-1 SUCCESS in 9m 00s
Skipped 43 jobs

changelogs/fragments/1631-route53_health_check-added-calculcated.yml

plugins/modules/route53_health_check.py

softwarefactory-project-zuul · 2023-07-05T15:14:03Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/94967ce8f48d4658940f7b01875ddd6d

✔️ ansible-galaxy-importer SUCCESS in 4m 05s
✔️ build-ansible-collection SUCCESS in 13m 25s
✔️ ansible-test-splitter SUCCESS in 4m 58s
✔️ integration-amazon.aws-1 SUCCESS in 8m 54s
Skipped 43 jobs

ansibullbot · 2023-07-12T17:45:19Z

cc @jillr @s-hertel @tremble @zimbatm
click here for bot help

plugins/modules/route53_health_check.py

softwarefactory-project-zuul · 2023-07-24T16:02:52Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/4de13d8f60634c95814c95bd9d800607

✔️ ansible-galaxy-importer SUCCESS in 4m 57s
✔️ build-ansible-collection SUCCESS in 13m 41s
✔️ ansible-test-splitter SUCCESS in 5m 18s
✔️ integration-amazon.aws-1 SUCCESS in 8m 34s
Skipped 43 jobs

softwarefactory-project-zuul · 2023-07-25T20:14:31Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/a050d69ca1684949bd342c0eb8e53a2b

✔️ ansible-galaxy-importer SUCCESS in 4m 27s
✔️ build-ansible-collection SUCCESS in 13m 27s
✔️ ansible-test-splitter SUCCESS in 4m 44s
✔️ integration-amazon.aws-1 SUCCESS in 10m 48s
Skipped 43 jobs

gravesm

Couple small things, but otherwise looks pretty good.

plugins/modules/route53_health_check.py

tests/integration/targets/route53_health_check/tasks/calculate_health_check.yml

softwarefactory-project-zuul · 2023-07-28T16:08:09Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/7a3f283209714a9494d36eaea0fa970b

✔️ ansible-galaxy-importer SUCCESS in 5m 39s
✔️ build-ansible-collection SUCCESS in 12m 28s
✔️ ansible-test-splitter SUCCESS in 4m 53s
✔️ integration-amazon.aws-1 SUCCESS in 9m 34s
Skipped 43 jobs

softwarefactory-project-zuul · 2023-07-31T11:46:23Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/368fd10f64ce47fbb98359e6d6dd36cd

✔️ ansible-galaxy-importer SUCCESS in 4m 15s
✔️ build-ansible-collection SUCCESS in 12m 57s
✔️ ansible-test-splitter SUCCESS in 4m 43s
✔️ integration-amazon.aws-1 SUCCESS in 10m 16s
Skipped 43 jobs

softwarefactory-project-zuul · 2023-07-31T21:40:02Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/878633934b5047c0a4268259109d7a98

✔️ ansible-galaxy-importer SUCCESS in 3m 45s
✔️ build-ansible-collection SUCCESS in 12m 35s
✔️ ansible-test-splitter SUCCESS in 6m 14s
❌ integration-amazon.aws-1 RETRY_LIMIT in 1m 30s
Skipped 43 jobs

…ed.yml Co-authored-by: Alina Buzachis <abuzachis@redhat.com>

…ould be different

softwarefactory-project-zuul · 2023-08-01T16:43:50Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/33678c14e73c4b1589003676267c3b47

✔️ ansible-galaxy-importer SUCCESS in 4m 28s
✔️ build-ansible-collection SUCCESS in 12m 53s
✔️ ansible-test-splitter SUCCESS in 5m 40s
✔️ integration-amazon.aws-1 SUCCESS in 9m 43s
Skipped 43 jobs

gravesm · 2023-08-01T16:51:21Z

regate

softwarefactory-project-zuul · 2023-08-01T17:18:09Z

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/952f9a86b8b04c17abe28a744cecfb65

✔️ ansible-galaxy-importer SUCCESS in 4m 24s
✔️ build-ansible-collection SUCCESS in 12m 50s
✔️ ansible-test-splitter SUCCESS in 4m 57s
❌ integration-amazon.aws-1 RETRY_LIMIT in 1m 32s
Skipped 43 jobs

gravesm · 2023-08-01T17:29:22Z

regate

softwarefactory-project-zuul · 2023-08-01T20:42:03Z

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/58438a1468e5454ba6823ad2c8b53297

✔️ ansible-galaxy-importer SUCCESS in 5m 29s
✔️ build-ansible-collection SUCCESS in 12m 56s
✔️ ansible-test-splitter SUCCESS in 5m 12s
✔️ integration-amazon.aws-1 SUCCESS in 11m 20s
✔️ integration-community.aws-1 SUCCESS in 40m 07s
✔️ integration-community.aws-2 SUCCESS in 23m 34s
✔️ integration-community.aws-3 SUCCESS in 40m 12s
✔️ integration-community.aws-4 SUCCESS in 43m 24s
✔️ integration-community.aws-5 SUCCESS in 5m 54s
✔️ integration-community.aws-6 SUCCESS in 22m 19s
✔️ integration-community.aws-7 SUCCESS in 26m 20s
✔️ integration-community.aws-8 SUCCESS in 24m 39s
✔️ integration-community.aws-9 SUCCESS in 35m 05s
✔️ integration-community.aws-10 SUCCESS in 30m 04s
✔️ integration-community.aws-11 SUCCESS in 33m 36s
✔️ integration-community.aws-12 SUCCESS in 13m 37s
✔️ integration-community.aws-13 SUCCESS in 24m 40s
✔️ integration-community.aws-14 SUCCESS in 43m 49s
✔️ integration-community.aws-15 SUCCESS in 15m 59s
✔️ integration-community.aws-16 SUCCESS in 48m 34s
✔️ integration-community.aws-17 SUCCESS in 16m 14s
✔️ integration-community.aws-18 SUCCESS in 17m 55s
✔️ integration-community.aws-19 SUCCESS in 12m 38s
Skipped 24 jobs

patchback · 2023-08-01T20:42:08Z

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/625777a125f6f0cad6035dcf166469684541185d/pr-1631

Backported as #1682

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

route53_health_check - add support for CALCULATED type SUMMARY Fixes #1442 ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/route53_health_check.py ADDITIONAL INFORMATION Reviewed-by: Helen Bailey <hebailey@redhat.com> Reviewed-by: Taeho Park Reviewed-by: Alina Buzachis Reviewed-by: Mike Graves <mgraves@redhat.com> (cherry picked from commit 625777a)

[PR #1631/625777a1 backport][stable-6] route53_health_check - add support for CALCULATED type This is a backport of PR #1631 as merged into main (625777a). SUMMARY Fixes #1442 ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/route53_health_check.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis

…ctions#1631) route53_health_check - add support for CALCULATED type SUMMARY Fixes ansible-collections#1442 ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/route53_health_check.py ADDITIONAL INFORMATION Reviewed-by: Helen Bailey <hebailey@redhat.com> Reviewed-by: Taeho Park Reviewed-by: Alina Buzachis Reviewed-by: Mike Graves <mgraves@redhat.com>

taehopark32 changed the title ~~[WIP] added CALCULATED to the feature~~ Add support for CALCULATED type in route53_health_check Jun 29, 2023

taehopark32 changed the title ~~Add support for CALCULATED type in route53_health_check~~ route53_health_check - add support for CALCULATED type Jun 30, 2023

hakbailey requested changes Jul 3, 2023

View reviewed changes

tests/integration/targets/route53_health_check/tasks/calculate_health_check.yml Show resolved Hide resolved

plugins/modules/route53_health_check.py Show resolved Hide resolved

alinabuzachis reviewed Jul 4, 2023

View reviewed changes

alinabuzachis added the backport-6 PR should be backported to the stable-6 branch label Jul 10, 2023

ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration module module plugins plugin (any type) tests tests labels Jul 12, 2023

hakbailey approved these changes Jul 24, 2023

View reviewed changes

plugins/modules/route53_health_check.py Outdated Show resolved Hide resolved

taehopark32 force-pushed the feature_idea branch from 373f7fa to 2be7d8b Compare July 24, 2023 14:20

hakbailey added this to the 6.3.0 milestone Jul 27, 2023

gravesm reviewed Jul 28, 2023

View reviewed changes

plugins/modules/route53_health_check.py Outdated Show resolved Hide resolved

tests/integration/targets/route53_health_check/tasks/calculate_health_check.yml Outdated Show resolved Hide resolved

alinabuzachis approved these changes Jul 31, 2023

View reviewed changes

alinabuzachis force-pushed the feature_idea branch from 64ff7ed to 0df7e03 Compare July 31, 2023 11:21

jillr force-pushed the feature_idea branch from 0df7e03 to 79c541d Compare July 31, 2023 21:19

jillr added the mergeit Merge the PR (SoftwareFactory) label Jul 31, 2023

taehopark32 and others added 15 commits August 1, 2023 12:06

added CALCULATED

4a5a350

added updates and test cases

3eec747

added description for documentation

517f139

added fragment

5b0cdd9

fixed trailing whitespace

7d8d540

fixed documentation issue

12eca14

made changes to the integration test and invalid parameter

3622976

fix format issue

c4ee0f6

fix linter issue

efda724

added check_mode into integration test

b5f6c0d

Update changelogs/fragments/1631-route53_health_check-added-calculcat…

416c9ce

…ed.yml Co-authored-by: Alina Buzachis <abuzachis@redhat.com>

added verions

032e1ba

add version to description

2785f17

moved calculate exception to mutually_exclusive argument

6f8c2a7

changed parameter description version and delete and cleanup tasks sh…

53f813d

…ould be different

taehopark32 force-pushed the feature_idea branch from 79c541d to 53f813d Compare August 1, 2023 16:06

softwarefactory-project-zuul bot merged commit 625777a into ansible-collections:main Aug 1, 2023
37 checks passed

patchback bot mentioned this pull request Aug 1, 2023

[PR #1631/625777a1 backport][stable-6] route53_health_check - add support for CALCULATED type #1682

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

route53_health_check - add support for CALCULATED type #1631

route53_health_check - add support for CALCULATED type #1631

taehopark32 commented Jun 28, 2023 •

edited

Loading

softwarefactory-project-zuul bot commented Jun 28, 2023

softwarefactory-project-zuul bot commented Jun 28, 2023

softwarefactory-project-zuul bot commented Jun 29, 2023

github-actions bot commented Jun 29, 2023 •

edited

Loading

softwarefactory-project-zuul bot commented Jun 29, 2023

softwarefactory-project-zuul bot commented Jul 3, 2023

softwarefactory-project-zuul bot commented Jul 3, 2023

softwarefactory-project-zuul bot commented Jul 5, 2023

ansibullbot commented Jul 12, 2023

softwarefactory-project-zuul bot commented Jul 24, 2023

softwarefactory-project-zuul bot commented Jul 25, 2023

gravesm left a comment

softwarefactory-project-zuul bot commented Jul 28, 2023

softwarefactory-project-zuul bot commented Jul 31, 2023

softwarefactory-project-zuul bot commented Jul 31, 2023

softwarefactory-project-zuul bot commented Aug 1, 2023

gravesm commented Aug 1, 2023

softwarefactory-project-zuul bot commented Aug 1, 2023

gravesm commented Aug 1, 2023

softwarefactory-project-zuul bot commented Aug 1, 2023

patchback bot commented Aug 1, 2023 •

edited

Loading

route53_health_check - add support for CALCULATED type #1631

route53_health_check - add support for CALCULATED type #1631

Conversation

taehopark32 commented Jun 28, 2023 • edited Loading

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

softwarefactory-project-zuul bot commented Jun 28, 2023

softwarefactory-project-zuul bot commented Jun 28, 2023

softwarefactory-project-zuul bot commented Jun 29, 2023

github-actions bot commented Jun 29, 2023 • edited Loading

Docs Build 📝

softwarefactory-project-zuul bot commented Jun 29, 2023

softwarefactory-project-zuul bot commented Jul 3, 2023

softwarefactory-project-zuul bot commented Jul 3, 2023

softwarefactory-project-zuul bot commented Jul 5, 2023

ansibullbot commented Jul 12, 2023

softwarefactory-project-zuul bot commented Jul 24, 2023

softwarefactory-project-zuul bot commented Jul 25, 2023

gravesm left a comment

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Jul 28, 2023

softwarefactory-project-zuul bot commented Jul 31, 2023

softwarefactory-project-zuul bot commented Jul 31, 2023

softwarefactory-project-zuul bot commented Aug 1, 2023

gravesm commented Aug 1, 2023

softwarefactory-project-zuul bot commented Aug 1, 2023

gravesm commented Aug 1, 2023

softwarefactory-project-zuul bot commented Aug 1, 2023

patchback bot commented Aug 1, 2023 • edited Loading

Backport to stable-6: 💚 backport PR created

taehopark32 commented Jun 28, 2023 •

edited

Loading

github-actions bot commented Jun 29, 2023 •

edited

Loading

patchback bot commented Aug 1, 2023 •

edited

Loading