Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudformation: add support for DisableRollback to upadte stack #1681

Conversation

mandar242
Copy link
Contributor

SUMMARY

Update stack operation supports DisableRollback.
Fixes #1655

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

cloudformation

ADDITIONAL INFORMATION

https://botocore.amazonaws.com/v1/documentation/api/latest/reference/services/cloudformation/client/update_stack.html

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/0d7525e0d856486da7e61c27d49040f3

✔️ ansible-galaxy-importer SUCCESS in 4m 15s
✔️ build-ansible-collection SUCCESS in 13m 19s
✔️ ansible-test-splitter SUCCESS in 5m 16s
✔️ integration-amazon.aws-1 SUCCESS in 9m 09s
Skipped 43 jobs

@ansibullbot
Copy link

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review has_issue module module needs_triage plugins plugin (any type) small_patch Hopefully easy to review labels Aug 1, 2023
@alinabuzachis alinabuzachis added this to the 6.4.0 milestone Aug 4, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/d922af96caea4350bbd4568873a5b600

✔️ ansible-galaxy-importer SUCCESS in 4m 26s
✔️ build-ansible-collection SUCCESS in 14m 18s
✔️ ansible-test-splitter SUCCESS in 6m 46s
✔️ integration-amazon.aws-1 SUCCESS in 8m 45s
Skipped 43 jobs

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/cbd29da0ebca4f94a2492e6e05a2c333

✔️ ansible-galaxy-importer SUCCESS in 6m 19s
✔️ build-ansible-collection SUCCESS in 12m 53s
✔️ ansible-test-splitter SUCCESS in 5m 20s
✔️ integration-amazon.aws-1 SUCCESS in 9m 30s
Skipped 43 jobs

@jillr jillr removed the needs_triage label Aug 8, 2023
@ansibullbot ansibullbot added integration tests/integration tests tests and removed small_patch Hopefully easy to review labels Aug 10, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/6998e7ef1ca3481d918954823d3be403

✔️ ansible-galaxy-importer SUCCESS in 3m 46s
✔️ build-ansible-collection SUCCESS in 13m 34s
✔️ ansible-test-splitter SUCCESS in 5m 26s
✔️ integration-amazon.aws-1 SUCCESS in 13m 49s
Skipped 43 jobs

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/b3e3f1ea7573432cb1b9350b1f86fe0d

✔️ ansible-galaxy-importer SUCCESS in 5m 16s
✔️ build-ansible-collection SUCCESS in 12m 34s
✔️ ansible-test-splitter SUCCESS in 5m 07s
integration-amazon.aws-1 RETRY_LIMIT in 8m 30s
Skipped 43 jobs

@mandar242
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/4a7d5ea8930c4a388004cf00e0f28efd

✔️ ansible-galaxy-importer SUCCESS in 4m 32s
✔️ build-ansible-collection SUCCESS in 12m 20s
✔️ ansible-test-splitter SUCCESS in 5m 04s
✔️ integration-amazon.aws-1 SUCCESS in 16m 25s
Skipped 43 jobs

@alinabuzachis
Copy link
Contributor

alinabuzachis commented Aug 31, 2023

@mandar242 I guess you need to rebase your PR. However, this is not a minor_change, is a bugfix because the option existed already (in stable-5 too), but it was not working. I also added the backport-5 label.

@alinabuzachis alinabuzachis added backport-6 PR should be backported to the stable-6 branch backport-5 PR should be backported to the stable-5 branch labels Aug 31, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/1ce166a8f6ff41e2a2078e09301e7d5e

✔️ ansible-galaxy-importer SUCCESS in 3m 42s
✔️ build-ansible-collection SUCCESS in 12m 28s
✔️ ansible-test-splitter SUCCESS in 4m 58s
✔️ integration-amazon.aws-1 SUCCESS in 12m 47s
Skipped 43 jobs

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/1bcf79a31d8640d296c0b249ff538c66

✔️ ansible-galaxy-importer SUCCESS in 4m 17s
✔️ build-ansible-collection SUCCESS in 12m 17s
✔️ ansible-test-splitter SUCCESS in 4m 41s
✔️ integration-amazon.aws-1 SUCCESS in 14m 19s
Skipped 43 jobs

@softwarefactory-project-zuul
Copy link
Contributor

Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/0b47ddaca0fa43a99be7a38f9cd74f43

✔️ ansible-galaxy-importer SUCCESS in 3m 38s
✔️ build-ansible-collection SUCCESS in 13m 18s
✔️ ansible-test-splitter SUCCESS in 4m 43s
✔️ integration-amazon.aws-1 SUCCESS in 13m 02s
Skipped 43 jobs

@softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/3c35a5818ddd4f9c90609e659cfea036

✔️ ansible-galaxy-importer SUCCESS in 4m 13s
✔️ build-ansible-collection SUCCESS in 14m 55s
✔️ ansible-test-splitter SUCCESS in 4m 58s
integration-amazon.aws-1 RETRY_LIMIT in 1m 41s
Skipped 43 jobs

@hakbailey
Copy link
Contributor

regate

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/854f285f9a5149c9b2df134a9057bb30

✔️ ansible-galaxy-importer SUCCESS in 4m 28s
✔️ build-ansible-collection SUCCESS in 12m 22s
✔️ ansible-test-splitter SUCCESS in 4m 47s
✔️ integration-amazon.aws-1 SUCCESS in 15m 08s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 46e9dd4 into ansible-collections:main Sep 1, 2023
36 checks passed
@patchback
Copy link

patchback bot commented Sep 1, 2023

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/46e9dd4aaf4add382cdfc2594a6da4b2f1521d24/pr-1681

Backported as #1726

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 1, 2023
cloudformation: add support for DisableRollback to upadte stack

SUMMARY

Update stack operation supports DisableRollback.
Fixes #1655

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

cloudformation
ADDITIONAL INFORMATION

https://botocore.amazonaws.com/v1/documentation/api/latest/reference/services/cloudformation/client/update_stack.html

Reviewed-by: Alina Buzachis
Reviewed-by: Mandar Kulkarni <mandar242@gmail.com>
Reviewed-by: Helen Bailey <hebailey@redhat.com>
(cherry picked from commit 46e9dd4)
@patchback
Copy link

patchback bot commented Sep 1, 2023

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/46e9dd4aaf4add382cdfc2594a6da4b2f1521d24/pr-1681

Backported as #1727

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 1, 2023
cloudformation: add support for DisableRollback to upadte stack

SUMMARY

Update stack operation supports DisableRollback.
Fixes #1655

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

cloudformation
ADDITIONAL INFORMATION

https://botocore.amazonaws.com/v1/documentation/api/latest/reference/services/cloudformation/client/update_stack.html

Reviewed-by: Alina Buzachis
Reviewed-by: Mandar Kulkarni <mandar242@gmail.com>
Reviewed-by: Helen Bailey <hebailey@redhat.com>
(cherry picked from commit 46e9dd4)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Sep 4, 2023
… (#1727)

[PR #1681/46e9dd4a backport][stable-6] cloudformation: add support for DisableRollback to upadte stack

This is a backport of PR #1681 as merged into main (46e9dd4).
SUMMARY

Update stack operation supports DisableRollback.
Fixes #1655

ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

cloudformation
ADDITIONAL INFORMATION



https://botocore.amazonaws.com/v1/documentation/api/latest/reference/services/cloudformation/client/update_stack.html

Reviewed-by: Alina Buzachis
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 4, 2023
…ble-collections#1681) (ansible-collections#1727)

[PR ansible-collections#1681/46e9dd4a backport][stable-6] cloudformation: add support for DisableRollback to upadte stack

This is a backport of PR ansible-collections#1681 as merged into main (46e9dd4).
SUMMARY

Update stack operation supports DisableRollback.
Fixes ansible-collections#1655

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

cloudformation
ADDITIONAL INFORMATION

https://botocore.amazonaws.com/v1/documentation/api/latest/reference/services/cloudformation/client/update_stack.html

Reviewed-by: Alina Buzachis
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Sep 18, 2023
v8.4.0

Major Changes
-------------

fortinet.fortios

- Improve the document for adding notes and examples in Q&A for modules using Integer number as the mkey.

Minor Changes
-------------

amazon.aws

- cloudformation - Add support for ``disable_rollback`` to update stack operation (ansible-collections/amazon.aws#1681).
- ec2_key - add support for new parameter ``file_name`` to save private key in when new key is created by AWS. When this option is provided the generated private key will be removed from the module return (ansible-collections/amazon.aws#1704).

ansible.netcommon

- Add a new cliconf plugin ``default`` that can be used when no cliconf plugin is found for a given network_os. This plugin only supports ``get()``. (ansible-collections/ansible.netcommon#569)
- httpapi - Add additional option ``ca_path``, ``client_cert``, ``client_key``, and ``http_agent`` that are available in open_url but not to httpapi. (ansible-collections/ansible.netcommon#528)
- telnet - add crlf option to send CRLF instead of just LF (ansible-collections/ansible.netcommon#440).

ansible.utils

- Add ipcut filter plugin.(ansible-collections/ansible.utils#251)
- Add ipv6form filter plugin.(ansible-collections/ansible.utils#230)

arista.eos

- Add support for overridden operation in bgp_global resource module.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-5 PR should be backported to the stable-5 branch backport-6 PR should be backported to the stable-6 branch bug This issue/PR relates to a bug community_review has_issue integration tests/integration mergeit Merge the PR (SoftwareFactory) module module plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

amazon.aws.cloudformation module update when failure
5 participants