Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default cliconf plugin good enough to use cli_command most of the time #569

Merged
merged 10 commits into from
Jul 27, 2023

Conversation

Qalthos
Copy link
Collaborator

@Qalthos Qalthos commented Jul 20, 2023

SUMMARY

This should simplify the zero-to-cli_command experience for new platforms (or very old ones).

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

cliconf/default

@Qalthos Qalthos added the feature This issue/PR relates to a feature request. label Jul 20, 2023
@Qalthos Qalthos force-pushed the default-cliconf branch 2 times, most recently from 275f00c to 0abec81 Compare July 20, 2023 19:13
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #569 (ab67bb0) into main (80fe09a) will decrease coverage by 1.20%.
The diff coverage is n/a.

❗ Current head ab67bb0 differs from pull request most recent head acbec77. Consider uploading reports for the commit acbec77 to get more accurate results

@@            Coverage Diff             @@
##             main     #569      +/-   ##
==========================================
- Coverage   64.47%   63.28%   -1.20%     
==========================================
  Files          31       33       +2     
  Lines        3868     4047     +179     
  Branches      685      717      +32     
==========================================
+ Hits         2494     2561      +67     
- Misses       1231     1342     +111     
- Partials      143      144       +1     

see 33 files with indirect coverage changes

@softwarefactory-project-zuul

This comment was marked as outdated.

@softwarefactory-project-zuul

This comment was marked as outdated.

@softwarefactory-project-zuul

This comment was marked as outdated.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/9be65c708243460ea5ff4f1c9f45bddb

ansible-test-network-integration-junos-vsrx-netconf-python36-stable29 FAILURE in 14m 24s (non-voting)
✔️ ansible-test-network-integration-junos-vsrx-netconf-python36-stable211 SUCCESS in 1h 16m 47s
✔️ ansible-test-network-integration-junos-vsrx-netconf-python39-stable212 SUCCESS in 1h 05m 26s
ansible-test-network-integration-junos-vsrx-netconf-python39 RETRY_LIMIT in 7m 54s
ansible-test-network-integration-junos-vsrx-network_cli-python36-stable29 FAILURE in 13m 01s (non-voting)
✔️ ansible-test-network-integration-junos-vsrx-network_cli-python36-stable211 SUCCESS in 17m 30s
✔️ ansible-test-network-integration-junos-vsrx-network_cli-python39-stable212 SUCCESS in 15m 39s
ansible-test-network-integration-junos-vsrx-network_cli-python39 NODE_FAILURE Node request 200-0006223821 failed in 0s
ansible-test-network-integration-junos-vsrx-network_cli-libssh-python36-stable29 FAILURE in 16m 51s (non-voting)
✔️ ansible-test-network-integration-junos-vsrx-network_cli-libssh-python36-stable211 SUCCESS in 17m 56s
✔️ ansible-test-network-integration-junos-vsrx-network_cli-libssh-python39-stable212 SUCCESS in 15m 57s
ansible-test-network-integration-junos-vsrx-network_cli-libssh-python39 RETRY_LIMIT in 7m 39s
ansible-test-network-integration-nxos-cli-python39-scenario01 RETRY_LIMIT in 5m 18s (non-voting)
ansible-test-network-integration-nxos-cli-python39-scenario02 RETRY_LIMIT in 5m 03s (non-voting)
ansible-test-network-integration-nxos-cli-python39-scenario03 RETRY_LIMIT in 5m 33s (non-voting)
ansible-test-network-integration-nxos-cli-python39-scenario04 RETRY_LIMIT in 5m 18s (non-voting)
ansible-test-network-integration-eos-network_cli-python39 RETRY_LIMIT in 7m 46s (non-voting)
ansible-test-network-integration-eos-httpapi-python39 RETRY_LIMIT in 6m 33s (non-voting)
ansible-test-network-integration-eos-network_cli-libssh-python39 RETRY_LIMIT in 5m 21s (non-voting)
ansible-ee-integration-ios-latest NODE_FAILURE Node request 200-0006223833 failed in 0s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 13m 29s (non-voting)
ansible-ee-integration-ios-stable-2.11 FAILURE in 14m 49s (non-voting)
ansible-ee-integration-ios-stable-2.12 FAILURE in 12m 39s (non-voting)
ansible-ee-integration-ios-libssh-latest FAILURE in 12m 19s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 12m 25s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 12m 21s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 13m 10s (non-voting)
ansible-test-network-integration-vyos-paramiko-python39-devel NODE_FAILURE Node request 200-0006223841 failed in 0s
ansible-test-network-integration-vyos-paramiko-python39-stable214 NODE_FAILURE Node request 200-0006223842 failed in 0s
ansible-test-network-integration-vyos-paramiko-python39-stable213 NODE_FAILURE Node request 200-0006223843 failed in 0s
ansible-test-network-integration-vyos-paramiko-python39-stable212 NODE_FAILURE Node request 200-0006223844 failed in 0s
ansible-test-network-integration-vyos-paramiko-python36-stable29 NODE_FAILURE Node request 200-0006223845 failed in 0s (non-voting)
ansible-test-network-integration-vyos-libssh-python39-devel NODE_FAILURE Node request 200-0006223846 failed in 0s
ansible-test-network-integration-vyos-libssh-python39-stable214 NODE_FAILURE Node request 200-0006223847 failed in 0s
ansible-test-network-integration-vyos-libssh-python39-stable213 NODE_FAILURE Node request 200-0006223848 failed in 0s
ansible-test-network-integration-vyos-libssh-python39-stable212 NODE_FAILURE Node request 200-0006223849 failed in 0s
ansible-test-network-integration-vyos-libssh-python36-stable29 NODE_FAILURE Node request 200-0006223850 failed in 0s
✔️ build-ansible-collection SUCCESS in 14m 50s
ansible-test-network-integration-ansible-netcommon-junos-vsrx-netconf-python39 RETRY_LIMIT in 7m 21s
✔️ ansible-tox-linters SUCCESS in 11m 08s
✔️ ansible-galaxy-importer SUCCESS in 4m 53s

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/6b28ebec10b74a3a83021415dcb1c7bf

ansible-test-network-integration-junos-vsrx-netconf-python36-stable29 FAILURE in 13m 03s (non-voting)
✔️ ansible-test-network-integration-junos-vsrx-netconf-python36-stable211 SUCCESS in 1h 15m 32s
✔️ ansible-test-network-integration-junos-vsrx-netconf-python39-stable212 SUCCESS in 1h 07m 36s
ansible-test-network-integration-junos-vsrx-netconf-python39 RETRY_LIMIT in 6m 49s
ansible-test-network-integration-junos-vsrx-network_cli-python36-stable29 FAILURE in 12m 28s (non-voting)
✔️ ansible-test-network-integration-junos-vsrx-network_cli-python36-stable211 SUCCESS in 16m 30s
✔️ ansible-test-network-integration-junos-vsrx-network_cli-python39-stable212 SUCCESS in 15m 21s
ansible-test-network-integration-junos-vsrx-network_cli-python39 RETRY_LIMIT in 1m 08s
ansible-test-network-integration-junos-vsrx-network_cli-libssh-python36-stable29 FAILURE in 13m 11s (non-voting)
ansible-test-network-integration-junos-vsrx-network_cli-libssh-python36-stable211 FAILURE in 14m 19s
✔️ ansible-test-network-integration-junos-vsrx-network_cli-libssh-python39-stable212 SUCCESS in 14m 37s
ansible-test-network-integration-junos-vsrx-network_cli-libssh-python39 RETRY_LIMIT in 8m 42s
ansible-test-network-integration-nxos-cli-python39-scenario01 RETRY_LIMIT in 5m 42s (non-voting)
ansible-test-network-integration-nxos-cli-python39-scenario02 RETRY_LIMIT in 6m 15s (non-voting)
ansible-test-network-integration-nxos-cli-python39-scenario03 RETRY_LIMIT in 5m 09s (non-voting)
ansible-test-network-integration-nxos-cli-python39-scenario04 RETRY_LIMIT in 6m 03s (non-voting)
ansible-test-network-integration-eos-network_cli-python39 RETRY_LIMIT in 5m 15s (non-voting)
ansible-test-network-integration-eos-httpapi-python39 RETRY_LIMIT in 5m 39s (non-voting)
ansible-test-network-integration-eos-network_cli-libssh-python39 RETRY_LIMIT in 8m 31s (non-voting)
ansible-ee-integration-ios-latest FAILURE in 11m 38s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 13m 12s (non-voting)
ansible-ee-integration-ios-stable-2.11 FAILURE in 13m 19s (non-voting)
ansible-ee-integration-ios-stable-2.12 FAILURE in 12m 41s (non-voting)
ansible-ee-integration-ios-libssh-latest FAILURE in 14m 15s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 14m 53s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 13m 07s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 14m 54s (non-voting)
ansible-test-network-integration-vyos-paramiko-python39-devel NODE_FAILURE Node request 200-0006224804 failed in 0s
ansible-test-network-integration-vyos-paramiko-python39-stable214 NODE_FAILURE Node request 200-0006224805 failed in 0s
ansible-test-network-integration-vyos-paramiko-python39-stable213 NODE_FAILURE Node request 200-0006224806 failed in 0s
ansible-test-network-integration-vyos-paramiko-python39-stable212 NODE_FAILURE Node request 200-0006224807 failed in 0s
ansible-test-network-integration-vyos-paramiko-python36-stable29 NODE_FAILURE Node request 200-0006224808 failed in 0s (non-voting)
ansible-test-network-integration-vyos-libssh-python39-devel NODE_FAILURE Node request 200-0006224809 failed in 0s
ansible-test-network-integration-vyos-libssh-python39-stable214 NODE_FAILURE Node request 200-0006224810 failed in 0s
ansible-test-network-integration-vyos-libssh-python39-stable213 NODE_FAILURE Node request 200-0006224811 failed in 0s
ansible-test-network-integration-vyos-libssh-python39-stable212 NODE_FAILURE Node request 200-0006224812 failed in 0s
ansible-test-network-integration-vyos-libssh-python36-stable29 NODE_FAILURE Node request 200-0006224813 failed in 0s
✔️ build-ansible-collection SUCCESS in 14m 49s
ansible-test-network-integration-ansible-netcommon-junos-vsrx-netconf-python39 RETRY_LIMIT in 6m 17s
✔️ ansible-tox-linters SUCCESS in 11m 05s
✔️ ansible-galaxy-importer SUCCESS in 5m 11s

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/e8234350a8e34002b11b2da6b85b9dd9

ansible-test-network-integration-junos-vsrx-netconf-python36-stable29 FAILURE in 14m 41s (non-voting)
✔️ ansible-test-network-integration-junos-vsrx-netconf-python36-stable211 SUCCESS in 1h 18m 32s
✔️ ansible-test-network-integration-junos-vsrx-netconf-python39-stable212 SUCCESS in 1h 09m 30s
ansible-test-network-integration-junos-vsrx-netconf-python39 RETRY_LIMIT in 8m 29s
ansible-test-network-integration-junos-vsrx-network_cli-python36-stable29 FAILURE in 12m 42s (non-voting)
✔️ ansible-test-network-integration-junos-vsrx-network_cli-python36-stable211 SUCCESS in 17m 58s
✔️ ansible-test-network-integration-junos-vsrx-network_cli-python39-stable212 SUCCESS in 15m 34s
ansible-test-network-integration-junos-vsrx-network_cli-python39 RETRY_LIMIT in 8m 19s
ansible-test-network-integration-junos-vsrx-network_cli-libssh-python36-stable29 FAILURE in 16m 12s (non-voting)
✔️ ansible-test-network-integration-junos-vsrx-network_cli-libssh-python36-stable211 SUCCESS in 16m 22s
ansible-test-network-integration-junos-vsrx-network_cli-libssh-python39-stable212 FAILURE in 13m 21s
ansible-test-network-integration-junos-vsrx-network_cli-libssh-python39 RETRY_LIMIT in 9m 00s
ansible-test-network-integration-nxos-cli-python39-scenario01 RETRY_LIMIT in 5m 27s (non-voting)
ansible-test-network-integration-nxos-cli-python39-scenario02 RETRY_LIMIT in 5m 08s (non-voting)
ansible-test-network-integration-nxos-cli-python39-scenario03 RETRY_LIMIT in 6m 47s (non-voting)
ansible-test-network-integration-nxos-cli-python39-scenario04 RETRY_LIMIT in 7m 54s (non-voting)
ansible-test-network-integration-eos-network_cli-python39 RETRY_LIMIT in 6m 33s (non-voting)
ansible-test-network-integration-eos-httpapi-python39 RETRY_LIMIT in 9m 18s (non-voting)
ansible-test-network-integration-eos-network_cli-libssh-python39 RETRY_LIMIT in 10m 21s (non-voting)
ansible-ee-integration-ios-latest FAILURE in 13m 20s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 13m 16s (non-voting)
ansible-ee-integration-ios-stable-2.11 FAILURE in 13m 18s (non-voting)
ansible-ee-integration-ios-stable-2.12 FAILURE in 16m 42s (non-voting)
ansible-ee-integration-ios-libssh-latest FAILURE in 13m 54s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 15m 45s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 12m 44s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 15m 47s (non-voting)
ansible-test-network-integration-vyos-paramiko-python39-devel NODE_FAILURE Node request 200-0006227604 failed in 0s
ansible-test-network-integration-vyos-paramiko-python39-stable214 NODE_FAILURE Node request 200-0006227605 failed in 0s
ansible-test-network-integration-vyos-paramiko-python39-stable213 NODE_FAILURE Node request 200-0006227606 failed in 0s
ansible-test-network-integration-vyos-paramiko-python39-stable212 NODE_FAILURE Node request 200-0006227607 failed in 0s
ansible-test-network-integration-vyos-paramiko-python36-stable29 NODE_FAILURE Node request 200-0006227608 failed in 0s (non-voting)
ansible-test-network-integration-vyos-libssh-python39-devel NODE_FAILURE Node request 200-0006227609 failed in 0s
ansible-test-network-integration-vyos-libssh-python39-stable214 NODE_FAILURE Node request 200-0006227610 failed in 0s
ansible-test-network-integration-vyos-libssh-python39-stable213 NODE_FAILURE Node request 200-0006227611 failed in 0s
ansible-test-network-integration-vyos-libssh-python39-stable212 NODE_FAILURE Node request 200-0006227612 failed in 0s
ansible-test-network-integration-vyos-libssh-python36-stable29 NODE_FAILURE Node request 200-0006227613 failed in 0s
✔️ build-ansible-collection SUCCESS in 14m 37s
ansible-test-network-integration-ansible-netcommon-junos-vsrx-netconf-python39 RETRY_LIMIT in 8m 42s
✔️ ansible-tox-linters SUCCESS in 10m 34s
✔️ ansible-galaxy-importer SUCCESS in 5m 03s

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/6679ee6b958e49c39398ddedfe969bf2

ansible-test-network-integration-junos-vsrx-netconf-python36-stable29 FAILURE in 21m 00s (non-voting)
✔️ ansible-test-network-integration-junos-vsrx-netconf-python36-stable211 SUCCESS in 1h 22m 30s
✔️ ansible-test-network-integration-junos-vsrx-netconf-python39-stable212 SUCCESS in 1h 09m 13s
ansible-test-network-integration-junos-vsrx-netconf-python39 RETRY_LIMIT in 9m 22s
ansible-test-network-integration-junos-vsrx-network_cli-python36-stable29 FAILURE in 14m 15s (non-voting)
✔️ ansible-test-network-integration-junos-vsrx-network_cli-python36-stable211 SUCCESS in 18m 27s
✔️ ansible-test-network-integration-junos-vsrx-network_cli-python39-stable212 SUCCESS in 17m 53s
ansible-test-network-integration-junos-vsrx-network_cli-python39 RETRY_LIMIT in 9m 34s
ansible-test-network-integration-junos-vsrx-network_cli-libssh-python36-stable29 FAILURE in 17m 10s (non-voting)
✔️ ansible-test-network-integration-junos-vsrx-network_cli-libssh-python36-stable211 SUCCESS in 17m 39s
✔️ ansible-test-network-integration-junos-vsrx-network_cli-libssh-python39-stable212 SUCCESS in 16m 40s
ansible-test-network-integration-junos-vsrx-network_cli-libssh-python39 RETRY_LIMIT in 5m 45s
ansible-test-network-integration-nxos-cli-python39-scenario01 RETRY_LIMIT in 5m 10s (non-voting)
ansible-test-network-integration-nxos-cli-python39-scenario02 RETRY_LIMIT in 5m 19s (non-voting)
ansible-test-network-integration-nxos-cli-python39-scenario03 RETRY_LIMIT in 5m 44s (non-voting)
ansible-test-network-integration-nxos-cli-python39-scenario04 RETRY_LIMIT in 5m 10s (non-voting)
ansible-test-network-integration-eos-network_cli-python39 RETRY_LIMIT in 5m 22s (non-voting)
ansible-test-network-integration-eos-httpapi-python39 RETRY_LIMIT in 9m 01s (non-voting)
ansible-test-network-integration-eos-network_cli-libssh-python39 RETRY_LIMIT in 9m 14s (non-voting)
ansible-ee-integration-ios-latest FAILURE in 12m 59s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 14m 07s (non-voting)
ansible-ee-integration-ios-stable-2.11 FAILURE in 12m 15s (non-voting)
ansible-ee-integration-ios-stable-2.12 FAILURE in 11m 44s (non-voting)
ansible-ee-integration-ios-libssh-latest FAILURE in 14m 25s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 13m 11s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 13m 30s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 13m 50s (non-voting)
ansible-test-network-integration-vyos-paramiko-python39-devel NODE_FAILURE Node request 200-0006231074 failed in 0s
ansible-test-network-integration-vyos-paramiko-python39-stable214 NODE_FAILURE Node request 200-0006231075 failed in 0s
ansible-test-network-integration-vyos-paramiko-python39-stable213 NODE_FAILURE Node request 200-0006231076 failed in 0s
ansible-test-network-integration-vyos-paramiko-python39-stable212 NODE_FAILURE Node request 200-0006231077 failed in 0s
ansible-test-network-integration-vyos-paramiko-python36-stable29 NODE_FAILURE Node request 200-0006231078 failed in 0s (non-voting)
ansible-test-network-integration-vyos-libssh-python39-devel NODE_FAILURE Node request 200-0006231079 failed in 0s
ansible-test-network-integration-vyos-libssh-python39-stable214 NODE_FAILURE Node request 200-0006231080 failed in 0s
ansible-test-network-integration-vyos-libssh-python39-stable213 NODE_FAILURE Node request 200-0006231081 failed in 0s
ansible-test-network-integration-vyos-libssh-python39-stable212 NODE_FAILURE Node request 200-0006231082 failed in 0s
ansible-test-network-integration-vyos-libssh-python36-stable29 NODE_FAILURE Node request 200-0006231083 failed in 0s
✔️ build-ansible-collection SUCCESS in 14m 44s
ansible-test-network-integration-ansible-netcommon-junos-vsrx-netconf-python39 RETRY_LIMIT in 11m 11s
✔️ ansible-tox-linters SUCCESS in 10m 42s
✔️ ansible-galaxy-importer SUCCESS in 4m 35s

@Qalthos Qalthos merged commit 07ef0c5 into ansible-collections:main Jul 27, 2023
52 of 53 checks passed
@Qalthos Qalthos deleted the default-cliconf branch July 27, 2023 02:07
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Sep 18, 2023
v8.4.0

Major Changes
-------------

fortinet.fortios

- Improve the document for adding notes and examples in Q&A for modules using Integer number as the mkey.

Minor Changes
-------------

amazon.aws

- cloudformation - Add support for ``disable_rollback`` to update stack operation (ansible-collections/amazon.aws#1681).
- ec2_key - add support for new parameter ``file_name`` to save private key in when new key is created by AWS. When this option is provided the generated private key will be removed from the module return (ansible-collections/amazon.aws#1704).

ansible.netcommon

- Add a new cliconf plugin ``default`` that can be used when no cliconf plugin is found for a given network_os. This plugin only supports ``get()``. (ansible-collections/ansible.netcommon#569)
- httpapi - Add additional option ``ca_path``, ``client_cert``, ``client_key``, and ``http_agent`` that are available in open_url but not to httpapi. (ansible-collections/ansible.netcommon#528)
- telnet - add crlf option to send CRLF instead of just LF (ansible-collections/ansible.netcommon#440).

ansible.utils

- Add ipcut filter plugin.(ansible-collections/ansible.utils#251)
- Add ipv6form filter plugin.(ansible-collections/ansible.utils#230)

arista.eos

- Add support for overridden operation in bgp_global resource module.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue/PR relates to a feature request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants