More fstring cleanup #1802
Merged
More fstring cleanup #1802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
alinabuzachis
approved these changes
Oct 13, 2023
This comment was marked as resolved.
This comment was marked as resolved.
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 51s |
This comment was marked as outdated.
This comment was marked as outdated.
|
regate |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 11s |
softwarefactory-project-zuul
bot
merged commit 06f8f53
into
ansible-collections:main
36 checks passed
tremble
added a commit
to ansible-collections/community.aws
that referenced
this pull request
Oct 17, 2023
SUMMARY Apply isort - see also ansible-collections/amazon.aws#1771 Apply flynt - see also ansible-collections/amazon.aws#1802 ISSUE TYPE Feature Pull Request COMPONENT NAME ADDITIONAL INFORMATION
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 20, 2023
SUMMARY Apply isort - see also ansible-collections#1771 Apply flynt - see also ansible-collections#1802 ISSUE TYPE Feature Pull Request COMPONENT NAME ADDITIONAL INFORMATION This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@c0117b5
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 26, 2023
SUMMARY Apply isort - see also ansible-collections#1771 Apply flynt - see also ansible-collections#1802 ISSUE TYPE Feature Pull Request COMPONENT NAME ADDITIONAL INFORMATION This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@c0117b5
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 27, 2023
SUMMARY Apply isort - see also ansible-collections#1771 Apply flynt - see also ansible-collections#1802 ISSUE TYPE Feature Pull Request COMPONENT NAME ADDITIONAL INFORMATION This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@c0117b5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Now that we're using tox for more of our linting tests, add flynt (encourage the use of fstrings)
ISSUE TYPE
COMPONENT NAME
plugins/modules/ec2_metadata_facts.pyplugins/modules/s3_object.py
pyproject.toml
tox.ini
ADDITIONAL INFORMATION
flynt was mass-applied as part of the 6.0.0 but we didn't update the linters.
Note: explicitly excludes
ec2_metadata_factsbecause this is expected to be run on managed nodes as well as the controllers. This is also why ec2_metadata_facts doesn't include botocore or our usual module wrapper.