[7.0.0] sort imports #1771
Merged
[7.0.0] sort imports #1771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
tremble
requested review from
alinabuzachis and
hakbailey
and removed request for
alinabuzachis
tremble
force-pushed
the
7.0.0/isort
branch
from
78a3111
to
b8cf3bb
Compare
alinabuzachis
approved these changes
Sep 28, 2023
tremble
force-pushed
the
7.0.0/isort
branch
from
b8cf3bb
to
028472c
Compare
tremble
force-pushed
the
7.0.0/isort
branch
from
a211867
to
8d1f80a
Compare
|
regate |
jillr
approved these changes
Sep 29, 2023
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Oct 2, 2023
* Add tox labels for lint, format and unit tests * [7.0.0] Apply isort to imports * Add isort to tox * Update workflow to run isort tests * changelog
tremble
added a commit
to ansible-collections/community.aws
that referenced
this pull request
Oct 17, 2023
SUMMARY Apply isort - see also ansible-collections/amazon.aws#1771 Apply flynt - see also ansible-collections/amazon.aws#1802 ISSUE TYPE Feature Pull Request COMPONENT NAME ADDITIONAL INFORMATION
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 20, 2023
SUMMARY Apply isort - see also ansible-collections#1771 Apply flynt - see also ansible-collections#1802 ISSUE TYPE Feature Pull Request COMPONENT NAME ADDITIONAL INFORMATION This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@c0117b5
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…nsible-collections#1773) (ansible-collections#1781) eks_nodegroup - fixing remote access and added to integration tests SUMMARY This was incorrectly merged directly into stable-5 rather than main. Fixes ansible-collections#1771 Handling remote_access configuration the right way that boto understands it. Also included it to integration tests. ISSUE TYPE Bugfix Pull Request COMPONENT NAME eks_nodegroup ADDITIONAL INFORMATION This is pulling ansible-collections#1773 from stable-5 into main Reviewed-by: Markus Bergholz Reviewed-by: Thomas Bruckmann Reviewed-by: Mark Chappell Reviewed-by: Markus Bergholz <git@osuv.de>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 26, 2023
SUMMARY Apply isort - see also ansible-collections#1771 Apply flynt - see also ansible-collections#1802 ISSUE TYPE Feature Pull Request COMPONENT NAME ADDITIONAL INFORMATION This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@c0117b5
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 27, 2023
SUMMARY Apply isort - see also ansible-collections#1771 Apply flynt - see also ansible-collections#1802 ISSUE TYPE Feature Pull Request COMPONENT NAME ADDITIONAL INFORMATION This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@c0117b5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Sort imports and add isort to the tox triggered linting
ISSUE TYPE
COMPONENT NAME
tox.ini
ADDITIONAL INFORMATION