-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add retries on the same failures as AWSRetry for the waiters #185
Add retries on the same failures as AWSRetry for the waiters #185
Conversation
63824c5
to
40370d9
Compare
40370d9
to
23f0650
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tremble the general idea seems sensible, could you please ci_complete this to be safe? I'd also like to do some testing of community.aws against this change (locally).
I've made it through half of the community.aws tests for modules with waiters with no issues so far |
8a29adb
to
51da5b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No other relevant test failures running this with community.aws modules (cloudfront_distribution is being difficult for unrelated reasons). LGTM - thanks @tremble!
* Prepare 1.1.0 release Run add_docs.py Run antsibull-changelog Bump release in galaxy.yml Update meta/runtime.yml with supported ansible revs Add requirements file to support execution environments Update amazon.aws rev in test requirements * Cleanup changelog formatting for new, sticter antsibull-changelog formatting Rerun add_docs.py with --branch-name flag Correct required amazon.aws revision to match the current in-progress release * add_docs generated bad markup, fix that This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@e95fb90
* Prepare 1.1.0 release Run add_docs.py Run antsibull-changelog Bump release in galaxy.yml Update meta/runtime.yml with supported ansible revs Add requirements file to support execution environments Update amazon.aws rev in test requirements * Cleanup changelog formatting for new, sticter antsibull-changelog formatting Rerun add_docs.py with --branch-name flag Correct required amazon.aws revision to match the current in-progress release * add_docs generated bad markup, fix that This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@e95fb90
* Prepare 1.1.0 release Run add_docs.py Run antsibull-changelog Bump release in galaxy.yml Update meta/runtime.yml with supported ansible revs Add requirements file to support execution environments Update amazon.aws rev in test requirements * Cleanup changelog formatting for new, sticter antsibull-changelog formatting Rerun add_docs.py with --branch-name flag Correct required amazon.aws revision to match the current in-progress release * add_docs generated bad markup, fix that
SUMMARY
Try getting our waiters to retry on the usual ratelimiting errors
ISSUE TYPE
COMPONENT NAME
plugins/module_utils/waiters.py
ADDITIONAL INFORMATION