Avoid unsafe conditionals in integration tests #1891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
abikouo
reviewed
Dec 1, 2023
| - "'engine_mode' in _result_tag_db_cluster" | ||
| - _result_tag_db_cluster.engine_mode == "provisioned" | ||
| - "'engine_version' in _result_tag_db_cluster" | ||
| - "'master_username' in _result_tag_db_cluster" | ||
| - _result_tag_db_cluster.master_username == "{{ username }}" | ||
| - _result_tag_db_cluster.master_username == username | ||
| - "'port' in _result_tag_db_cluster" | ||
| - _result_tag_db_cluster.port == {{ port }} |
There was a problem hiding this comment.
what about this kind of assertion?
tremble
requested changes
Dec 1, 2023
tests/integration/targets/elb_classic_lb/tasks/https_listeners.yml
Outdated
Show resolved
Hide resolved
tests/integration/targets/elb_classic_lb/tasks/https_listeners.yml
Outdated
Show resolved
Hide resolved
tests/integration/targets/elb_classic_lb/tasks/https_listeners.yml
Outdated
Show resolved
Hide resolved
tests/integration/targets/elb_classic_lb/tasks/https_listeners.yml
Outdated
Show resolved
Hide resolved
tests/integration/targets/ec2_instance_metadata_options/tasks/main.yml
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
abikouo
previously requested changes
Dec 1, 2023
tremble
requested changes
Dec 1, 2023
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
alinabuzachis
approved these changes
Dec 4, 2023
tremble
approved these changes
Dec 4, 2023
tremble
force-pushed
the
port_asserts
branch
3 times, most recently
from
1b67b18
to
46d08d3
Compare
Update a batch of assertions in integration tests to avoid templating See: ansible/ansible-documentation#866 and ansible/ansible-documentation#866
Co-authored-by: Bikouo Aubin <79859644+abikouo@users.noreply.github.com>
…e're expecting (and it has the things we're testing for)
|
recheck |
|
recheck |
softwarefactory-project-zuul
bot
merged commit dc08059
into
ansible-collections:main
39 checks passed
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #1903 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Dec 5, 2023
Avoid unsafe conditionals in integration tests SUMMARY Update a batch of assertions in integration tests to avoid templating See: ansible/ansible-documentation#866 and ansible/ansible-documentation#866 for more information This PR covers about half of the impacted test tasks for this repo but is already going to be a lot to get through CI so additional PRs will follow. Affected tasks identified with: https://gist.github.com/sivel/7b012ae2ebf4ab4cb6225379a72cc502 ISSUE TYPE Bugfix Pull Request COMPONENT NAME tests ADDITIONAL INFORMATION There are unsupported tests in this change. The cloudtrail tests seem to be broken independent of this change, iam_group tests pass for me locally Reviewed-by: Bikouo Aubin Reviewed-by: Mark Chappell Reviewed-by: Alina Buzachis Reviewed-by: Mike Graves <mgraves@redhat.com> (cherry picked from commit dc08059)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Dec 5, 2023
[PR #1891/dc080593 backport][stable-7] Avoid unsafe conditionals in integration tests This is a backport of PR #1891 as merged into main (dc08059). SUMMARY Update a batch of assertions in integration tests to avoid templating See: ansible/ansible-documentation#866 and ansible/ansible-documentation#866 for more information This PR covers about half of the impacted test tasks for this repo but is already going to be a lot to get through CI so additional PRs will follow. Affected tasks identified with: https://gist.github.com/sivel/7b012ae2ebf4ab4cb6225379a72cc502 ISSUE TYPE Bugfix Pull Request COMPONENT NAME tests ADDITIONAL INFORMATION There are unsupported tests in this change. The cloudtrail tests seem to be broken independent of this change, iam_group tests pass for me locally Reviewed-by: Mark Chappell
Merged
patchback bot
pushed a commit
that referenced
this pull request
Feb 22, 2024
Fix unsafe conditional SUMMARY This fixes an unsafe conditional in integration tests that was missed by our previous mass updates for unsafe conditionals (#1891 and #1911). ISSUE TYPE Bugfix Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell Reviewed-by: Alina Buzachis (cherry picked from commit dc7a3fb)
patchback bot
pushed a commit
that referenced
this pull request
Feb 22, 2024
Fix unsafe conditional SUMMARY This fixes an unsafe conditional in integration tests that was missed by our previous mass updates for unsafe conditionals (#1891 and #1911). ISSUE TYPE Bugfix Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell Reviewed-by: Alina Buzachis (cherry picked from commit dc7a3fb)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Feb 23, 2024
[PR #1984/dc7a3fb2 backport][stable-7] Fix unsafe conditional This is a backport of PR #1984 as merged into main (dc7a3fb). SUMMARY This fixes an unsafe conditional in integration tests that was missed by our previous mass updates for unsafe conditionals (#1891 and #1911). ISSUE TYPE Bugfix Pull Request COMPONENT NAME ADDITIONAL INFORMATION
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Feb 26, 2024
[PR #1984/dc7a3fb2 backport][stable-6] Fix unsafe conditional This is a backport of PR #1984 as merged into main (dc7a3fb). SUMMARY This fixes an unsafe conditional in integration tests that was missed by our previous mass updates for unsafe conditionals (#1891 and #1911). ISSUE TYPE Bugfix Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Update a batch of assertions in integration tests to avoid templating
See: ansible/ansible-documentation#866 and ansible/ansible-documentation#866 for more information
This PR covers about half of the impacted test tasks for this repo but is already going to be a lot to get through CI so additional PRs will follow.
Affected tasks identified with:
https://gist.github.com/sivel/7b012ae2ebf4ab4cb6225379a72cc502
ISSUE TYPE
COMPONENT NAME
tests
ADDITIONAL INFORMATION
There are unsupported tests in this change. The cloudtrail tests seem to be broken independent of this change, iam_group tests pass for me locally