Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add porting guide for CVE-2023-5764 [stable-2.16] #866

Merged
merged 1 commit into from Nov 27, 2023

Conversation

sivel
Copy link
Member

@sivel sivel commented Nov 27, 2023

Add porting guide for CVE-2023-5764

ansible/ansible#82293

This is not a traditional backport, there is no related devel change at this time.

Copy link
Member

@nitzmahone nitzmahone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This text looks oddly familiar- approved! 😉

@samccann samccann merged commit 970f6bd into ansible:stable-2.16 Nov 27, 2023
8 checks passed
@samccann
Copy link
Contributor

Hmm did I jump the gun on merging this @sivel ? Will core-2.16.1 go out soon or not til Dec 4? I saw CVE and my eyes just glazed over with URGENT URGENT ;-)

@sivel
Copy link
Member Author

sivel commented Nov 27, 2023

I think it'll be ok. We just released rc1 today, so I think it's fine.

jillr added a commit to jillr/amazon.aws that referenced this pull request Nov 30, 2023
Update a batch of assertions in integration tests to avoid templating

See: ansible/ansible-documentation#866 and
ansible/ansible-documentation#866
tremble pushed a commit to jillr/amazon.aws that referenced this pull request Dec 4, 2023
Update a batch of assertions in integration tests to avoid templating

See: ansible/ansible-documentation#866 and
ansible/ansible-documentation#866
tremble pushed a commit to jillr/amazon.aws that referenced this pull request Dec 4, 2023
Update a batch of assertions in integration tests to avoid templating

See: ansible/ansible-documentation#866 and
ansible/ansible-documentation#866
softwarefactory-project-zuul bot pushed a commit to ansible-collections/amazon.aws that referenced this pull request Dec 5, 2023
Avoid unsafe conditionals in integration tests

SUMMARY
Update a batch of assertions in integration tests to avoid templating
See: ansible/ansible-documentation#866 and ansible/ansible-documentation#866 for more information
This PR covers about half of the impacted test tasks for this repo but is already going to be a lot to get through CI so additional PRs will follow.
Affected tasks identified with:
https://gist.github.com/sivel/7b012ae2ebf4ab4cb6225379a72cc502
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
tests
ADDITIONAL INFORMATION
There are unsupported tests in this change.  The cloudtrail tests seem to be broken independent of this change, iam_group tests pass for me locally

Reviewed-by: Bikouo Aubin
Reviewed-by: Mark Chappell
Reviewed-by: Alina Buzachis
Reviewed-by: Mike Graves <mgraves@redhat.com>
patchback bot pushed a commit to ansible-collections/amazon.aws that referenced this pull request Dec 5, 2023
Avoid unsafe conditionals in integration tests

SUMMARY
Update a batch of assertions in integration tests to avoid templating
See: ansible/ansible-documentation#866 and ansible/ansible-documentation#866 for more information
This PR covers about half of the impacted test tasks for this repo but is already going to be a lot to get through CI so additional PRs will follow.
Affected tasks identified with:
https://gist.github.com/sivel/7b012ae2ebf4ab4cb6225379a72cc502
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
tests
ADDITIONAL INFORMATION
There are unsupported tests in this change.  The cloudtrail tests seem to be broken independent of this change, iam_group tests pass for me locally

Reviewed-by: Bikouo Aubin
Reviewed-by: Mark Chappell
Reviewed-by: Alina Buzachis
Reviewed-by: Mike Graves <mgraves@redhat.com>
(cherry picked from commit dc08059)
@gotmax23
Copy link
Collaborator

gotmax23 commented Dec 5, 2023

I'm submitting a "frontport" to devel. We need this on devel to show up in the combined Ansible changelog. Once I finish automating #66 and can rely on these tags being present, I'll change antsibull to pull core porting guides from tagged releases.

gotmax23 pushed a commit to gotmax23/ansible-documentation that referenced this pull request Dec 5, 2023
@sivel
Copy link
Member Author

sivel commented Dec 5, 2023

I'm submitting a "frontport" to devel

This is already completed in #931

@gotmax23
Copy link
Collaborator

gotmax23 commented Dec 5, 2023

Okay, it looks like we had a race coniditon. Thanks for handling it!

@gotmax23
Copy link
Collaborator

gotmax23 commented Dec 5, 2023

Can you also backport the 2.15 porting guide changes to stable-2.16 so folks viewing the latest documentation see the correct thing when viewing that porting guide?

@sivel
Copy link
Member Author

sivel commented Dec 5, 2023

Haha. Yes I can, do we need 2.14 also in the 2.16 branch?

softwarefactory-project-zuul bot pushed a commit to ansible-collections/amazon.aws that referenced this pull request Dec 5, 2023
[PR #1891/dc080593 backport][stable-7] Avoid unsafe conditionals in integration tests

This is a backport of PR #1891 as merged into main (dc08059).
SUMMARY
Update a batch of assertions in integration tests to avoid templating
See: ansible/ansible-documentation#866 and ansible/ansible-documentation#866 for more information
This PR covers about half of the impacted test tasks for this repo but is already going to be a lot to get through CI so additional PRs will follow.
Affected tasks identified with:
https://gist.github.com/sivel/7b012ae2ebf4ab4cb6225379a72cc502
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
tests
ADDITIONAL INFORMATION
There are unsupported tests in this change.  The cloudtrail tests seem to be broken independent of this change, iam_group tests pass for me locally

Reviewed-by: Mark Chappell
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants