Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ec2_vpc_dhcp_option to use boto3 (breaking change) #252

Merged
merged 13 commits into from
Apr 29, 2021
Merged

Refactor ec2_vpc_dhcp_option to use boto3 (breaking change) #252

merged 13 commits into from
Apr 29, 2021

Commits on Apr 29, 2021

  1. Refactor ec2_vpc_dhcp_option to use boto3 

    * Convert to boto3
* More consistent use of check_mode
* Use AwsRetry
* Catch BotoCoreError, ClientError
    @jillr
    jillr committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    9fc52ad View commit details
    Browse the repository at this point in the history

  2. Ongoing refactoring

    @jillr
    jillr committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    a0f2d9b View commit details
    Browse the repository at this point in the history

  3. Ongoing rewrite, start updating tests

    @jillr
    jillr committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    b8dcd5f View commit details
    Browse the repository at this point in the history

  4. refactoring largely complete, fix tag return in ec2_vpc_dhcp_option_info

    @jillr
    jillr committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    b4b5a55 View commit details
    Browse the repository at this point in the history

  5. Add unit tests, cleanup some quotes in module and tests

    @jillr
    jillr committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    09a684c View commit details
    Browse the repository at this point in the history

  6. Return boto3-style result as well

    @jillr
    jillr committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    ad3cdd7 View commit details
    Browse the repository at this point in the history

  7. sanity fix

    @jillr
    jillr committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    ee7fe47 View commit details
    Browse the repository at this point in the history

  8. Make the module and info module return both the boto-structured confi… 

    …g and the

user-friendly "normalized" comnfig.
Move the normalize_config function to module_utils
Enable integration test assertions for new return values, including tags
    @jillr
    jillr committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    bc78869 View commit details
    Browse the repository at this point in the history

  9. address review feedback

    @jillr
    jillr committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    48d2714 View commit details
    Browse the repository at this point in the history

  10. Return dhcp_config from ec2_vpc_dhcp_option and deprecate new_config.

    @jillr
    jillr committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    95e62ac View commit details
    Browse the repository at this point in the history

  11. whitespace sanity fix

    @tremble @jillr
    tremble authored and jillr committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    a5f2d3e View commit details
    Browse the repository at this point in the history

  12. Add ignore for pylint:ansible-deprecated-no-version (ansible-2.9)

    @tremble @jillr
    tremble authored and jillr committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    a3cd932 View commit details
    Browse the repository at this point in the history

  13. remove duplicate contains

    @tremble @jillr
    tremble authored and jillr committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    4f49c39 View commit details
    Browse the repository at this point in the history