Add comments to sanity ignore files explaining why things are ignored #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
community_review
needs_triage
tests
|
Hmm #280 didn't get merged (confusion around other cleanup?). Reviving. |
goneri
approved these changes
Mar 5, 2021
s-hertel
reviewed
Mar 5, 2021
tremble
force-pushed
the
pylint
branch
2 times, most recently
from
e8cfead
to
fa57b47
Compare
|
recheck |
This was referenced Mar 6, 2021
|
Simplified down to just the comments - some fixups may take a while to pull in. |
|
Because I've dropped this back down the the comment updates, and @goneri already +1ed that, I'm going to merge this (test failure looks to be a missing dependency in zuul somewhere) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
While in theory it's possible to track down the origin of sanity ignore entries by digging through commit histories this is work that would need to be done every time anyone wanted to cleanup. Add comments instead.
ISSUE TYPE
COMPONENT NAME
sanity
ADDITIONAL INFORMATION