Skip to content

Commit

Permalink
address pylint errors
Browse files Browse the repository at this point in the history
This commit addresses the three following pylint errors:

- plugins/module_utils/cloud.py:145:27: isinstance-second-argument-not-valid-type: Second argument of isinstance is not a type
- plugins/module_utils/cloudfront_facts.py:166:0: unnecessary-comprehension: Unnecessary use of a comprehension
- plugins/module_utils/core.py:192:4: property-with-parameters: Cannot have defined parameters for properties
  • Loading branch information
goneri authored and tremble committed Mar 5, 2021
1 parent fa57b47 commit e8cfead
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion plugins/module_utils/cloudfront_facts.py
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ def summary_get_distribution_list(self, streaming=False):
temp_distribution = {}
for key_name in key_list:
temp_distribution[key_name] = dist[key_name]
temp_distribution['Aliases'] = [alias for alias in dist['Aliases'].get('Items', [])]
temp_distribution['Aliases'] = dist['Aliases'].get('Items', [])
temp_distribution['ETag'] = self.get_etag_from_distribution_id(dist['Id'], streaming)
if not streaming:
temp_distribution['WebACLId'] = dist['WebACLId']
Expand Down
1 change: 0 additions & 1 deletion plugins/module_utils/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,6 @@ def resource(self, service):
return boto3_conn(self, conn_type='resource', resource=service,
region=region, endpoint=ec2_url, **aws_connect_kwargs)

@property
def region(self, boto3=True):
return get_aws_region(self, boto3)

Expand Down

0 comments on commit e8cfead

Please sign in to comment.