-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the default module requirements from python-2.6/boto to python-3.6/botocore-1.16 (breaking change) #298
Update the default module requirements from python-2.6/boto to python-3.6/botocore-1.16 (breaking change) #298
Conversation
@jillr in your presentation I think you suggested dropping 2.7 support as a part of the 2.0.0 release since boto3 is going to drop support soon. If we're going to do that I guess we update the python requirement in here to 3.6 rather than 2.7. |
recheck |
@tremble Yeah 1.5 will be the last 2.x supporting release, so we can bump this to py3.6 for collection version 2.0 |
8c9518d
to
a123e26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm very excited about this PR. :) LGTM once the merge conflict is resolved.
@tremble do you have a PR queued up to add the boto requirement to community modules that are still boto2 or shall I take care of that?
b07bd5c
to
38d10ac
Compare
38d10ac
to
66b6f0f
Compare
@jillr I don't currently have a PR lined up for community.aws but I can get that lined up in the next couple of days, was mostly waiting on this to land (and decisions from your side on version support policies) I've also added botocore >= 1.16.0 based on the policy in ansible/ansible#74585 (in theory we could bump this to something around 1.16.5 or even 1.17.0 but now there's a general policy outlined I'd be inclined to go slightly older (and with .0 release) knowing we can bump it with the next 'major' release. |
5a4d7bf
to
aacc85c
Compare
recheck |
aacc85c
to
ffa10d3
Compare
Update the default module requirements from python 2.6/boto to python 3.6/boto3 SUMMARY The vast bulk of modules are now boto3 based, but some even list python2.6/boto as their requirements because they've picked the default from the aws docs fragment. Switch the defaults over to reduce the copy&paste and reflect that boto v2 is deprecated python 2.6 is no longer supported by the AWS collections ISSUE TYPE Docs Pull Request COMPONENT NAME lots of them ADDITIONAL INFORMATION Depends-On: ansible-collections/amazon.aws#298 Reviewed-by: Jill R <None> Reviewed-by: Alina Buzachis <None>
…s/require-boto3 Update the default module requirements from python 2.6/boto to python 3.6/boto3 SUMMARY The vast bulk of modules are now boto3 based, but some even list python2.6/boto as their requirements because they've picked the default from the aws docs fragment. Switch the defaults over to reduce the copy&paste and reflect that boto v2 is deprecated python 2.6 is no longer supported by the AWS collections ISSUE TYPE Docs Pull Request COMPONENT NAME lots of them ADDITIONAL INFORMATION Depends-On: ansible-collections/amazon.aws#298 Reviewed-by: Jill R <None> Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@f186c9a
…s/require-boto3 Update the default module requirements from python 2.6/boto to python 3.6/boto3 SUMMARY The vast bulk of modules are now boto3 based, but some even list python2.6/boto as their requirements because they've picked the default from the aws docs fragment. Switch the defaults over to reduce the copy&paste and reflect that boto v2 is deprecated python 2.6 is no longer supported by the AWS collections ISSUE TYPE Docs Pull Request COMPONENT NAME lots of them ADDITIONAL INFORMATION Depends-On: ansible-collections/amazon.aws#298 Reviewed-by: Jill R <None> Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@f186c9a
…s/require-boto3 Update the default module requirements from python 2.6/boto to python 3.6/boto3 SUMMARY The vast bulk of modules are now boto3 based, but some even list python2.6/boto as their requirements because they've picked the default from the aws docs fragment. Switch the defaults over to reduce the copy&paste and reflect that boto v2 is deprecated python 2.6 is no longer supported by the AWS collections ISSUE TYPE Docs Pull Request COMPONENT NAME lots of them ADDITIONAL INFORMATION Depends-On: ansible-collections/amazon.aws#298 Reviewed-by: Jill R <None> Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@3692d16
…boto3 Update the default module requirements from python 2.6/boto to python 3.6/boto3 SUMMARY The vast bulk of modules are now boto3 based, but some even list python2.6/boto as their requirements because they've picked the default from the aws docs fragment. Switch the defaults over to reduce the copy&paste and reflect that boto v2 is deprecated python 2.6 is no longer supported by the AWS collections ISSUE TYPE Docs Pull Request COMPONENT NAME lots of them ADDITIONAL INFORMATION Depends-On: ansible-collections/amazon.aws#298 Reviewed-by: Jill R <None> Reviewed-by: Alina Buzachis <None>
…boto3 Update the default module requirements from python 2.6/boto to python 3.6/boto3 SUMMARY The vast bulk of modules are now boto3 based, but some even list python2.6/boto as their requirements because they've picked the default from the aws docs fragment. Switch the defaults over to reduce the copy&paste and reflect that boto v2 is deprecated python 2.6 is no longer supported by the AWS collections ISSUE TYPE Docs Pull Request COMPONENT NAME lots of them ADDITIONAL INFORMATION Depends-On: ansible-collections/amazon.aws#298 Reviewed-by: Jill R <None> Reviewed-by: Alina Buzachis <None>
…boto3 Update the default module requirements from python 2.6/boto to python 3.6/boto3 SUMMARY The vast bulk of modules are now boto3 based, but some even list python2.6/boto as their requirements because they've picked the default from the aws docs fragment. Switch the defaults over to reduce the copy&paste and reflect that boto v2 is deprecated python 2.6 is no longer supported by the AWS collections ISSUE TYPE Docs Pull Request COMPONENT NAME lots of them ADDITIONAL INFORMATION Depends-On: ansible-collections/amazon.aws#298 Reviewed-by: Jill R <None> Reviewed-by: Alina Buzachis <None>
…boto3 Update the default module requirements from python 2.6/boto to python 3.6/boto3 SUMMARY The vast bulk of modules are now boto3 based, but some even list python2.6/boto as their requirements because they've picked the default from the aws docs fragment. Switch the defaults over to reduce the copy&paste and reflect that boto v2 is deprecated python 2.6 is no longer supported by the AWS collections ISSUE TYPE Docs Pull Request COMPONENT NAME lots of them ADDITIONAL INFORMATION Depends-On: ansible-collections#298 Reviewed-by: Jill R <None> Reviewed-by: Alina Buzachis <None>
Depends-On: #302
SUMMARY
The vast bulk of modules are now boto3 based, but some even list python2.6/boto as their requirements because they've picked the default from the aws docs fragment.
Switch the defaults over to reduce the copy&paste and reflect that
ISSUE TYPE
COMPONENT NAME
plugins/doc_fragments/aws.py
ADDITIONAL INFORMATION
Should wait for the 2.0 release so we can cleanly update everything.