Improve state and config changes in ec2_instance #370
Conversation
jillr
changed the title
|
WIP while we work out the zuul changes in the linked PR |
|
recheck |
1 similar comment
|
recheck |
ansibullbot
added
WIP
|
recheck |
jillr
changed the title
|
recheck |
jillr
force-pushed
the
ec2_instance_state_handling
branch
from
84f221c
to
9fece09
Compare
|
recheck |
2 similar comments
|
recheck |
|
recheck |
jillr
force-pushed
the
ec2_instance_state_handling
branch
from
1ea0e13
to
b55fd6c
Compare
Fixes: community.aws/issues/16 This patch ensures that when changing state and/or supported parameters for an instance, changes are applied regardless of the starting or desired state of the instance.
jillr
force-pushed
the
ec2_instance_state_handling
branch
from
b55fd6c
to
71cf248
Compare
|
recheck |
1 similar comment
|
recheck |
|
The tests passed on my machine. ;) Different integration test failure each time the last two runs, and they look to be bog standard "sometimes ec2_instance times are a touch flaky". Will keep rechecking. Sanity tests are passing though! |
|
recheck |
|
ready_for_review |
There was a problem hiding this comment.
Hey @jillr thanks for this change! I was able to install the change locally but unfortunately my role has changed and I'm somewhat removed from the areas where this was being used, and I wasn't able to actually run it myself. I did look over the code though, and the tests you have look like they test the right thing! :)
I can't see the test results (are the tests in AWS collections run elsewhere?) but I assume they worked correctly. Thanks again!
|
Thanks @briantist! Shippable was discontinuted so we're using Zuul now. You have to click the "details" on ansible/check, then follow the link to the integration tests, then hit the console tab. |
|
Ah! Thank you, I see them now. |
…ble-collections#370) * Added 'worker_type' and 'glue_version' attributes to the module * fix: fixed compare_glue_job_params to compare the new attributes * Added changelog - fragments * Minor docs tweaks
…ble-collections#370) * Added 'worker_type' and 'glue_version' attributes to the module * fix: fixed compare_glue_job_params to compare the new attributes * Added changelog - fragments * Minor docs tweaks
…ble-collections#370) * Added 'worker_type' and 'glue_version' attributes to the module * fix: fixed compare_glue_job_params to compare the new attributes * Added changelog - fragments * Minor docs tweaks
Depends-On: ansible/ansible-zuul-jobs#915
Depends-On: #381
SUMMARY
This patch ensures that when changing state and/or supported parameters for an instance, changes are applied regardless of the starting or desired state of the instance.
Fixes: #380
ISSUE TYPE
COMPONENT NAME
ec2_instance