-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ignore py2 errors #381
ignore py2 errors #381
Conversation
goneri
commented
Jun 2, 2021
•
edited
Loading
edited
- ignore all the errors with pre-3.8 Python
- add a script to refresh the ignores files easily
@goneri: Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information. Here are the items we could not find in your description:
Please set the description of this pullrequest with this template: |
Can we use the --skip-test option instead of mass-adding ignore entries? |
- ignore all the errors with pre-3.8 Python - add a script to refresh the ignores files easily
ce6d6f2
to
39f483b
Compare
We cannot use |
I don't quite get why we care about not totally turning off the Python 2.6/2.7/3.5 tests, but I'll not push here. |
@tremble I would also prefer to avoid hundreds of ignores (community.aws is going to be "fun") but in the immediate term we can't keep blocking CI. :( |
They test with Python 3.6 only. This is another approach that we can take, but we will still need to have the ignore files at some point because of AutomationHub. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm when #370 passes (contains 3-only changes)
@tremble I've open this a while ago: ansible/ansible#74398. @mattclay has since pushed a new feature that give the ability to disable a Python version. But it won't be backported. |
We only support Python 3.8 now. This commit had: - a script to refresh the ignore files: tests/sanity/refresh_ignore_files - the ignore files. See: ansible-collections/amazon.aws#381
370 sanity is passing now (the integration failures are unrelated). thanks @goneri! |
We only support Python 3.8 now. This commit had: - a script to refresh the ignore files: tests/sanity/refresh_ignore_files - the ignore files. See: ansible-collections/amazon.aws#381
We only support Python 3.8 now. This commit had: - a script to refresh the ignore files: tests/sanity/refresh_ignore_files - the ignore files. See: ansible-collections/amazon.aws#381