Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ec2_instance: Add count parameter to ec2_instance #539
ec2_instance: Add count parameter to ec2_instance #539
Changes from 14 commits
cea17fd
f60c6a7
a5ec52a
c17d238
9142575
e9fff0a
7be7807
8664ad1
be0ce65
38d7395
45a1dad
fe37a6d
9634fd5
d518e39
aae4f2f
1a0819e
b3fed8d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could overwrite
module.params['count']
here to avoid the extra code path inbuild_run_instance_spec
@jillr do you have any opinions on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I generally don't like overwriting module.params, I worry that it's asking for issues down the road when we make some other change that uses
count
and expects it to be whatever the user originally specified. I think I'd rather have the extra conditional?