Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ec2_vol: set iops even if unchanged for boto req #606

Merged

Conversation

lowlydba
Copy link
Contributor

@lowlydba lowlydba commented Jan 8, 2022

SUMMARY

Set the iops value in req_obj even if the target iops is the same as the existing. This is a required parameter for boto's modify_volume. Fixes #605

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ec2_vol

@lowlydba
Copy link
Contributor Author

lowlydba commented Jan 9, 2022

recheck

@lowlydba lowlydba changed the title set iops even if unchanged for boto req ec2_vol: set iops even if unchanged for boto req Jan 9, 2022
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jillr jillr added the backport-2 PR should be backported to the stable-2 branch label Jan 12, 2022
@lowlydba
Copy link
Contributor Author

@jillr Can this also get a backport-1.5 tag as well 🙏🏻

@ansible-zuul ansible-zuul bot merged commit 038c047 into ansible-collections:main Jan 12, 2022
@patchback
Copy link

patchback bot commented Jan 12, 2022

Backport to stable-2: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2/038c0474ea01d274e0c46fe1f1e2e77769624bff/pr-606

Backported as #612

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 12, 2022
ec2_vol: set iops even if unchanged for boto req

SUMMARY

Set the iops value in req_obj even if the target iops is the same as the existing. This is a required parameter for boto's modify_volume. Fixes #605
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
ec2_vol

Reviewed-by: None <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
(cherry picked from commit 038c047)
@jillr jillr added the backport-1.5 PR should be backported to the stable-1.5 branch label Jan 14, 2022
@patchback
Copy link

patchback bot commented Jan 14, 2022

Backport to stable-1.5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-1.5/038c0474ea01d274e0c46fe1f1e2e77769624bff/pr-606

Backported as #614

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 14, 2022
ec2_vol: set iops even if unchanged for boto req

SUMMARY

Set the iops value in req_obj even if the target iops is the same as the existing. This is a required parameter for boto's modify_volume. Fixes #605
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
ec2_vol

Reviewed-by: None <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
(cherry picked from commit 038c047)
ansible-zuul bot pushed a commit that referenced this pull request Jan 14, 2022
[PR #606/038c0474 backport][stable-2] ec2_vol: set iops even if unchanged for boto req

This is a backport of PR #606 as merged into main (038c047).
SUMMARY

Set the iops value in req_obj even if the target iops is the same as the existing. This is a required parameter for boto's modify_volume. Fixes #605
ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME
ec2_vol

Reviewed-by: Jill R <None>
Reviewed-by: None <None>
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Apr 12, 2022
…hanged for boto req (#614)

[PR #606/038c0474 backport][stable-1.5] ec2_vol: set iops even if unchanged for boto req

Depends-On: #753
This is a backport of PR #606 as merged into main (038c047).
SUMMARY

Set the iops value in req_obj even if the target iops is the same as the existing. This is a required parameter for boto's modify_volume. Fixes #605
ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME
ec2_vol
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-1.5 PR should be backported to the stable-1.5 branch backport-2 PR should be backported to the stable-2 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ec2_vol passes null iops to boto when changing type w/ existing iops value
4 participants