-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ec2_vpc_route_table - support associating internet gateways #690
ec2_vpc_route_table - support associating internet gateways #690
Conversation
@jatorcasso I'll debug the module ec2_vpc_igw module tomorrow, but if you want to anticipate feel free to do it. |
recheck |
recheck |
recheck |
recheck |
This change depends on a change that failed to merge. |
recheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just minor things - otherwise LGTM!
recheck |
recheck |
It hangs merging and it seems the requests have been addressed.
regate |
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #757 🤖 @patchback |
ec2_vpc_route_table - support associating internet gateways Depends-On: ansible/ansible-zuul-jobs#1362 Depends-On: ansible/ansible-zuul-jobs#1364 SUMMARY Update ec2_vpc_route_table to support associating internet gateways per feature request #476 Add integration tests Fix idempotency issue when associating a subnet with a route table ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_vpc_route_table Reviewed-by: Mandar Kulkarni <mandar242@gmail.com> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Abhijeet Kasurde <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None> Reviewed-by: Mike Graves <mgraves@redhat.com> Reviewed-by: Mark Chappell <None> Reviewed-by: Mark Woolley <mw@marknet15.com> (cherry picked from commit d9d5d0d)
) [PR #690/d9d5d0d7 backport][stable-3] ec2_vpc_route_table - support associating internet gateways This is a backport of PR #690 as merged into main (d9d5d0d). Depends-On: ansible/ansible-zuul-jobs#1362 Depends-On: ansible/ansible-zuul-jobs#1364 SUMMARY Update ec2_vpc_route_table to support associating internet gateways per feature request #476 Add integration tests Fix idempotency issue when associating a subnet with a route table ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_vpc_route_table
…collections#690) (ansible-collections#757) [PR ansible-collections#690/d9d5d0d7 backport][stable-3] ec2_vpc_route_table - support associating internet gateways This is a backport of PR ansible-collections#690 as merged into main (d9d5d0d). Depends-On: ansible/ansible-zuul-jobs#1362 Depends-On: ansible/ansible-zuul-jobs#1364 SUMMARY Update ec2_vpc_route_table to support associating internet gateways per feature request ansible-collections#476 Add integration tests Fix idempotency issue when associating a subnet with a route table ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_vpc_route_table
Depends-On: ansible/ansible-zuul-jobs#1362
Depends-On: ansible/ansible-zuul-jobs#1364
SUMMARY
ISSUE TYPE
COMPONENT NAME
ec2_vpc_route_table