Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tagging docs fragment - comment cleanup (C&P) #857

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jun 2, 2022

SUMMARY

When creating the docs fragment in #844 the comment above the fragments was left behind from the fragment I used as a base, tweak the comment.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

plugins/doc_fragments/tags.py

ADDITIONAL INFORMATION

@tremble tremble added the backport-3 PR should be backported to the stable-3 branch label Jun 2, 2022
@ansibullbot ansibullbot added community_review docs plugins plugin (any type) small_patch Hopefully easy to review labels Jun 2, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 5m 09s
✔️ build-ansible-collection SUCCESS in 4m 47s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 9m 53s
✔️ ansible-test-sanity-aws-ansible-2.9-python38 SUCCESS in 15m 16s
✔️ ansible-test-sanity-aws-ansible-2.11-python38 SUCCESS in 9m 34s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 01s
✔️ ansible-test-splitter SUCCESS in 2m 47s
⚠️ integration-amazon.aws-1 SKIPPED
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
✔️ integration-community.aws-1 SUCCESS in 7m 24s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jun 7, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 08s
✔️ build-ansible-collection SUCCESS in 4m 56s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 9m 41s
✔️ ansible-test-sanity-aws-ansible-2.9-python38 SUCCESS in 12m 15s
✔️ ansible-test-sanity-aws-ansible-2.11-python38 SUCCESS in 9m 43s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 28s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 25s
✔️ ansible-test-splitter SUCCESS in 2m 28s
⚠️ integration-amazon.aws-1 SKIPPED
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
✔️ integration-community.aws-1 SUCCESS in 6m 54s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit de57ec4 into ansible-collections:main Jun 7, 2022
@patchback
Copy link

patchback bot commented Jun 7, 2022

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/de57ec4a1dcdf3baabeba41f668bd39e11ab55ed/pr-857

Backported as #867

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jun 7, 2022
tagging docs fragment - comment cleanup (C&P)

SUMMARY
When creating the docs fragment in #844 the comment above the fragments was left behind from the fragment I used as a base, tweak the comment.
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
plugins/doc_fragments/tags.py
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
(cherry picked from commit de57ec4)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jun 7, 2022
[PR #857/de57ec4a backport][stable-3] tagging docs fragment - comment cleanup (C&P)

This is a backport of PR #857 as merged into main (de57ec4).
SUMMARY
When creating the docs fragment in #844 the comment above the fragments was left behind from the fragment I used as a base, tweak the comment.
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
plugins/doc_fragments/tags.py
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>
jatorcasso pushed a commit to jatorcasso/amazon.aws that referenced this pull request Jun 27, 2022
tagging docs fragment - comment cleanup (C&P)

SUMMARY
When creating the docs fragment in ansible-collections#844 the comment above the fragments was left behind from the fragment I used as a base, tweak the comment.
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
plugins/doc_fragments/tags.py
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
@tremble tremble deleted the tagging/docs_comment branch September 9, 2022 08:50
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 16, 2022
Lambda - Wait before updating

SUMMARY

Updated lambda module to wait for State = Active & LastUpdateStatus = Successful based on https://aws.amazon.com/blogs/compute/coming-soon-expansion-of-aws-lambda-states-to-all-functions/

Fixes ansible-collections#830
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

module: lambda
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <git@osuv.de>
Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@ab4bda2
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 16, 2022
Lambda - Wait before updating

SUMMARY

Updated lambda module to wait for State = Active & LastUpdateStatus = Successful based on https://aws.amazon.com/blogs/compute/coming-soon-expansion-of-aws-lambda-states-to-all-functions/

Fixes ansible-collections#830
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

module: lambda
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <git@osuv.de>
Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@ab4bda2
goneri pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 21, 2022
Lambda - Wait before updating

SUMMARY

Updated lambda module to wait for State = Active & LastUpdateStatus = Successful based on https://aws.amazon.com/blogs/compute/coming-soon-expansion-of-aws-lambda-states-to-all-functions/

Fixes ansible-collections#830
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

module: lambda
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <git@osuv.de>
Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@ab4bda2
goneri pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 21, 2022
Lambda - Wait before updating

SUMMARY

Updated lambda module to wait for State = Active & LastUpdateStatus = Successful based on https://aws.amazon.com/blogs/compute/coming-soon-expansion-of-aws-lambda-states-to-all-functions/

Fixes ansible-collections#830
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

module: lambda
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <git@osuv.de>
Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@ab4bda2
goneri pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 21, 2022
Lambda - Wait before updating

SUMMARY

Updated lambda module to wait for State = Active & LastUpdateStatus = Successful based on https://aws.amazon.com/blogs/compute/coming-soon-expansion-of-aws-lambda-states-to-all-functions/

Fixes ansible-collections#830
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

module: lambda
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <git@osuv.de>
Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@ab4bda2
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
Lambda - Wait before updating

SUMMARY

Updated lambda module to wait for State = Active & LastUpdateStatus = Successful based on https://aws.amazon.com/blogs/compute/coming-soon-expansion-of-aws-lambda-states-to-all-functions/

Fixes ansible-collections#830
ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

module: lambda
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <git@osuv.de>
Reviewed-by: Alina Buzachis <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
Lambda - Wait before updating

SUMMARY

Updated lambda module to wait for State = Active & LastUpdateStatus = Successful based on https://aws.amazon.com/blogs/compute/coming-soon-expansion-of-aws-lambda-states-to-all-functions/

Fixes ansible-collections#830
ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

module: lambda
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <git@osuv.de>
Reviewed-by: Alina Buzachis <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
Lambda - Wait before updating

SUMMARY

Updated lambda module to wait for State = Active & LastUpdateStatus = Successful based on https://aws.amazon.com/blogs/compute/coming-soon-expansion-of-aws-lambda-states-to-all-functions/

Fixes ansible-collections#830
ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

module: lambda
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <git@osuv.de>
Reviewed-by: Alina Buzachis <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3 PR should be backported to the stable-3 branch community_review docs mergeit Merge the PR (SoftwareFactory) plugins plugin (any type) small_patch Hopefully easy to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants