ec2_security_group: Set rules->group_name's datatype as raw #971
Conversation
Signed-off-by: GomathiselviS <gomathiselvi@gmail.com>
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
ansibullbot
added
community_review
docs
module
There was a problem hiding this comment.
Hi @GomathiselviS,
Thanks for taking the time to open this PR.
Given that string and list-of-string are the valid inputs for the option it would be better to define the type='list' and elements='str'. However, looking at the code, I'm not 100% sure it would actually handle a list rather than just a string...
changelogs/fragments/638-ec2_security_group_group_name_datatype.yml
Outdated
Show resolved
Hide resolved
Hi @tremble , I tested the module with "group_name" as both str and list of strings, and the task succeeded in both cases. I understand that this line handles the conversion. The doc has examples for both the cases, hence I marked the data type as raw. Please let me know your views. |
…e.yml Co-authored-by: Mark Chappell <mchappel@redhat.com>
In that case the best bet is to set |
|
recheck |
tremble
added
backport-3
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #973 🤖 @patchback |
ec2_security_group: Set rules->group_name's datatype as raw Signed-off-by: GomathiselviS gomathiselvi@gmail.com SUMMARY rules-> group_name can accept values of type list and str. ISSUE TYPE Docs Pull Request COMPONENT NAME ec2_security_group.py ADDITIONAL INFORMATION Reviewed-by: Mark Chappell <None> (cherry picked from commit 9e7ae6c)
Backport to stable-4: 💚 backport PR created✅ Backport PR branch: Backported as #974 🤖 @patchback |
ec2_security_group: Set rules->group_name's datatype as raw Signed-off-by: GomathiselviS gomathiselvi@gmail.com SUMMARY rules-> group_name can accept values of type list and str. ISSUE TYPE Docs Pull Request COMPONENT NAME ec2_security_group.py ADDITIONAL INFORMATION Reviewed-by: Mark Chappell <None> (cherry picked from commit 9e7ae6c)
) [PR #971/9e7ae6cf backport][stable-4] ec2_security_group: Set rules->group_name's datatype as raw This is a backport of PR #971 as merged into main (9e7ae6c). Signed-off-by: GomathiselviS gomathiselvi@gmail.com SUMMARY rules-> group_name can accept values of type list and str. ISSUE TYPE Docs Pull Request COMPONENT NAME ec2_security_group.py ADDITIONAL INFORMATION
) [PR #971/9e7ae6cf backport][stable-3] ec2_security_group: Set rules->group_name's datatype as raw This is a backport of PR #971 as merged into main (9e7ae6c). Signed-off-by: GomathiselviS gomathiselvi@gmail.com SUMMARY rules-> group_name can accept values of type list and str. ISSUE TYPE Docs Pull Request COMPONENT NAME ec2_security_group.py ADDITIONAL INFORMATION Reviewed-by: Jill R <None> Reviewed-by: Alina Buzachis <None>
elb_application_lb - treat empty security group as VPC default SUMMARY Fixes idempotency issue when security_groups = [] by treating [] as using the VPC's default security group (like it does on creation). Fixes #28 Used same logic as amazon.aws.ec2_vpc_route_table does for using default igw Added integration tests ISSUE TYPE Bugfix Pull Request COMPONENT NAME elb_application_lb Reviewed-by: Jill R <None> Reviewed-by: Mark Woolley <mw@marknet15.com> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@20b726a
…le-collections#971) elb_application_lb - treat empty security group as VPC default SUMMARY Fixes idempotency issue when security_groups = [] by treating [] as using the VPC's default security group (like it does on creation). Fixes ansible-collections#28 Used same logic as amazon.aws.ec2_vpc_route_table does for using default igw Added integration tests ISSUE TYPE Bugfix Pull Request COMPONENT NAME elb_application_lb Reviewed-by: Jill R <None> Reviewed-by: Mark Woolley <mw@marknet15.com> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@20b726a
…le-collections#971) elb_application_lb - treat empty security group as VPC default SUMMARY Fixes idempotency issue when security_groups = [] by treating [] as using the VPC's default security group (like it does on creation). Fixes ansible-collections#28 Used same logic as amazon.aws.ec2_vpc_route_table does for using default igw Added integration tests ISSUE TYPE Bugfix Pull Request COMPONENT NAME elb_application_lb Reviewed-by: Jill R <None> Reviewed-by: Mark Woolley <mw@marknet15.com>
…le-collections#971) elb_application_lb - treat empty security group as VPC default SUMMARY Fixes idempotency issue when security_groups = [] by treating [] as using the VPC's default security group (like it does on creation). Fixes ansible-collections#28 Used same logic as amazon.aws.ec2_vpc_route_table does for using default igw Added integration tests ISSUE TYPE Bugfix Pull Request COMPONENT NAME elb_application_lb Reviewed-by: Jill R <None> Reviewed-by: Mark Woolley <mw@marknet15.com>
…le-collections#971) elb_application_lb - treat empty security group as VPC default SUMMARY Fixes idempotency issue when security_groups = [] by treating [] as using the VPC's default security group (like it does on creation). Fixes ansible-collections#28 Used same logic as amazon.aws.ec2_vpc_route_table does for using default igw Added integration tests ISSUE TYPE Bugfix Pull Request COMPONENT NAME elb_application_lb Reviewed-by: Jill R <None> Reviewed-by: Mark Woolley <mw@marknet15.com>
Signed-off-by: GomathiselviS gomathiselvi@gmail.com
SUMMARY
rules-> group_name can accept values of type list and str.
ISSUE TYPE
COMPONENT NAME
ec2_security_group.py
ADDITIONAL INFORMATION