merge s3_url parameter into endpoint_url #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
ansibullbot
added
community_review
feature
This comment was marked as resolved.
This comment was marked as resolved.
tremble
force-pushed
the
params/s3_url
branch
from
3229f36
to
85a7119
Compare
This comment was marked as resolved.
This comment was marked as resolved.
tremble
force-pushed
the
params/s3_url
branch
from
85a7119
to
abbaefb
Compare
alinabuzachis
approved these changes
Sep 6, 2022
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
(related to #992)
s3_urlparameter intoendpoint_url. This makes the modules more consistent with the rest of the collection.rgwas an alias to thecephparameter in s3_bucket, and renamesrgwtoceph(keeping an alias) in s3_object.ISSUE TYPE
COMPONENT NAME
plugins/modules/s3_bucket.py
plugins/modules/s3_object.py
ADDITIONAL INFORMATION