Fix config templating on Ansible 5 #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Blefish What is Ansible 5? |
jlec
approved these changes
Dec 29, 2021
|
@lanefu Ansible-5 is the latest release of Ansible. |
|
hmmm I guess I live too much in the world of Ansible core |
|
Thanks for the fix and merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Ansible 5, lookup function produces string output (new default? I couldn't find any confirmation about this). Applying to_nice_json provides a double encapsulated JSON output, which is invalid for Consul.
I'd like some feedback as I have only tested this on Linux so far with Ansible 5. Not sure if this is backwards compatible or maybe Ansible introduced a breaking change unindentionally.
Some more info here: ansible/ansible#76443