Added azure cli credential support in the azure_keyvault_secret.py plugin #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Fred-sun, thanks a lot for this. Is there also a room for MSI auth? the modules having all the auth methods as well and MSI auth through Azure CLI wont work. |
|
@jkroepke This is in order! If the ansible host is MSI enabled Azure VM, It will use MSI auth. Thank you very much! |
|
I could not agree by reading the code https://github.com/ansible-collections/azure/pull/1161/files#diff-3b014a0ef829e0b9df07b0d6bc06da01e063fac5dbecf71cafa8bd02aec61380R167-R176 but I will trust you. |
|
@jkroepke If we want to use azure cli credential, we must obtain it through subscriptioin_id, thanks! |
Fred-sun
added
ready_for_review
xuzhang3
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added azure cli credential support in the azure_keyvault_secret.py plugin， try to fixes #1088
SUMMARY
ISSUE TYPE
COMPONENT NAME
azure_keyvault_secret.py
ADDITIONAL INFORMATION