Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added azure cli credential support in the azure_keyvault_secret.py plugin #1161

Merged
merged 3 commits into from
May 31, 2023
Merged

Added azure cli credential support in the azure_keyvault_secret.py plugin #1161

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
492a893
Added azure cli credential support in the azure_keyvault_secret.py pl…
Fred-sun May 11, 2023
c861e74
Fix sanity error
Fred-sun May 11, 2023
bc9d04a
Update azure_keyvault_secret.py
Fred-sun May 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions plugins/lookup/azure_keyvault_secret.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@
description: Secret of the service principal.
tenant_id:
description: Tenant id of service principal.
subscription_id:
description: Your Azure subscription Id.
notes:
- If version is not provided, this plugin will return the latest version of the secret.
- If ansible is running on Azure Virtual Machine with MSI enabled, client_id, secret and tenant isn't required.
Expand All @@ -42,6 +44,9 @@
"""

EXAMPLE = """
- name: Look up secret when azure cli login
debug:
msg: msg: "{{ lookup('azure.azcollection.azure_keyvault_secret', 'testsecret', vault_url=key_vault_uri, subscription_id=subscription_id)}}"
- name: Look up secret when ansible host is MSI enabled Azure VM
debug:
msg: "the value of this secret is {{
Expand Down Expand Up @@ -111,7 +116,7 @@
import requests
import logging
import os
from azure.common.credentials import ServicePrincipalCredentials
from azure.common.credentials import ServicePrincipalCredentials, get_cli_profile
from azure.keyvault import KeyVaultClient
from msrest.exceptions import AuthenticationError, ClientRequestError
from azure.keyvault.models.key_vault_error import KeyVaultErrorException
Expand Down Expand Up @@ -155,13 +160,19 @@ def lookup_secret_non_msi(terms, vault_url, kwargs):
client_id = kwargs['client_id'] if kwargs.get('client_id') else os.environ.get('AZURE_CLIENT_ID')
secret = kwargs['secret'] if kwargs.get('secret') else os.environ.get('AZURE_SECRET')
tenant_id = kwargs['tenant_id'] if kwargs.get('tenant_id') else os.environ.get('AZURE_TENANT')
subscription_id = kwargs['subscription_id'] if kwargs.get('subscription_id') else os.environ.get('AZURE_SUBSCRIPTION_ID')

try:
credentials = ServicePrincipalCredentials(
client_id=client_id,
secret=secret,
tenant=tenant_id
)
if client_id is not None and secret is not None and tenant_id is not None:
credentials = ServicePrincipalCredentials(
client_id=client_id,
secret=secret,
tenant=tenant_id
)
elif subscription_id is not None:
profile = get_cli_profile()
credentials, subscription_id, tenant = profile.get_login_credentials(
subscription_id=subscription_id, resource="https://vault.azure.net")
client = KeyVaultClient(credentials)
except AuthenticationError:
raise AnsibleError('Invalid credentials provided.')
Expand Down