Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #331 removed static commercial cloud references #351

Closed

Conversation

opfpqgoon
Copy link
Contributor

SUMMARY

Fixed references to azure cloud environment statically assigned to Azure Commercial

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

azure_rm_keyvaultkey
azure_rm_keyvaultkeyinfo
azure_rm_keyvaultsecret
azure_rm_keyvaultsecret_info

ADDITIONAL INFORMATION

@opfpqgoon opfpqgoon marked this pull request as ready for review December 4, 2020 20:11
@Fred-sun
Copy link
Collaborator

@opfpqgoon Thank you for your contribution, please help to fix these files conflict! Thank you very much!

@Ompragash
Copy link
Member

@opfpqgoon Could you kindly check the file conflicts?

@Fred-sun
Copy link
Collaborator

kinldy ping!

@Fred-sun
Copy link
Collaborator

Fred-sun commented Jun 8, 2021

@opfpqgoon Can you help resolve conflicts in PR? We are reviewing these PR recently and pushing forward the merger. Thank you!

@Fred-sun
Copy link
Collaborator

duplicate with #356 has merged)

@Fred-sun Fred-sun closed this Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants