Conditionally call MSI auth when interacting with keyvault

[opfpqgoon]

SUMMARY

MSI auth shouldn't be used unless the module specifically calls for it. Currently MSI will be tried anytime the modules are called from an Azure VM, even if the MSI doesn't (and shouldn't) have access to the keyvault.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

azure_rm_keyvaultsecret
azure_rm_keyvaultsecret_info
azure_rm_keyvaultkey
azure_rm_keyvaultkey_info

ADDITIONAL INFORMATION

[Fred-sun]

@opfpqgoon

ERROR: plugins/modules/azure_rm_keyvaultkey.py:185:9: E115: expected an indented block (comment)
ERROR: plugins/modules/azure_rm_keyvaultkey.py:185:9: E265: block comment should start with '# '
ERROR: plugins/modules/azure_rm_keyvaultkey_info.py:320:9: E115: expected an indented block (comment)
ERROR: plugins/modules/azure_rm_keyvaultkey_info.py:320:9: E265: block comment should start with '# '
ERROR: plugins/modules/azure_rm_keyvaultsecret.py:184:9: E115: expected an indented block (comment)
ERROR: plugins/modules/azure_rm_keyvaultsecret.py:184:9: E265: block comment should start with '# '
ERROR: plugins/modules/azure_rm_keyvaultsecret_info.py:274:9: E115: expected an indented block (comment)
ERROR: plugins/modules/azure_rm_keyvaultsecret_info.py:274:9: E265: block comment should start with '# '

[Fred-sun]

@opfpqgoon Can I make some updates to some of the Sanity errors above? Thank you very much!

[opfpqgoon]

Please do!

…

On Feb 7, 2021, at 03:51, Fred-sun ***@***.***> wrote:  @opfpqgoon Can I make some updates to some of the Sanity errors above? Thank you very much! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[Fred-sun]

@haiyuazhang