Fixed mismatch assignment error

[Spacebjorn]

SUMMARY

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

azure_rm_roleassignment.py

ADDITIONAL INFORMATION

Errpr code: "msg": "State Mismatch Error: The assignment name exists, but does not match the provided role"

Changing the fatal message to print the elif comparison statement will show:
Error code: "msg": "role_assignment.get(): b7e6dc6d-f1e8-4753-8033-0f276bb0955b self.role_definition_id: b"

After my suggested change the code will actually do a proper comparison ending up with:
"msg": "role_assignment.get(): b7e6dc6d-f1e8-4753-8033-0f276bb0955b self.role_definition_id: b7e6dc6d-f1e8-4753-8033-0f276bb0955b"

Trying to rerun the code below will result in the error saying there's a mismatch between the roles even though a azure.azcollection.azure_rm_roleassignment_info task to the role will show they're the exact same.

    azure.azcollection.azure_rm_roleassignment:
      name: "{{ (ansible_azure_subscription_id + '/' + managed_identity_id + '/b7e6dc6d-f1e8-4753-8033-0f276bb0955b') | to_uuid }}"
      scope:
        "/subscriptions/{{ ansible_azure_subscription_id }}\
        /resourceGroups/{{ resource_group_name }}\
        /providers/Microsoft.Storage/storageAccounts/{{ storage_account_name }}"
      assignee_object_id: "{{ managed_identity_id }}"
      role_definition_id:
        "/subscriptions/{{ ansible_azure_subscription_id }}\
        /providers/Microsoft.Authorization/roleDefinitions/b7e6dc6d-f1e8-4753-8033-0f276bb0955b"
      state: present

[Fred-sun]

@Spacebjorn Line306 should not be consistent with the change here! Thank you very much!

azure/plugins/modules/azure_rm_roleassignment.py

Line 306 in d79a5f1

if role_assignment and self.role_definition_id and (role_assignment.get('role_definition_id').split('/')[-1].lower()

[Spacebjorn]

@Fred-sun Should be fixed for both lines now. Good catch

[paultaiton]

@Spacebjorn
Nice fix. I think I developed the faulty bit before I fully understood how to run the integration tests, because how they're written it should have caught this bug.

[Spacebjorn]

@paultaiton I would've thought the integration tests would run as prereq before merging as well?

[Spacebjorn]

@Fred-sun Not to be rude, but is there any status on this PR? It doesn't change that much and the task is still broken if you rerun it

[xuzhang3]

@Spacebjorn LGTM