Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix os_type comparison in azure_rm_manageddisk with existing disk #621

Merged
merged 6 commits into from
Apr 14, 2022

Conversation

nbr23
Copy link
Contributor

@nbr23 nbr23 commented Aug 27, 2021

SUMMARY

Fix os_type comparison in azure_rm_manageddisk always returning true.

The current comparison was happening between a string (eg linux) and a OperatingSystemTypes variable (eg OperatingSystemTypes.linux), always returning True.
This impacts the value of the changed variable, signaling a change when none was done.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • azure_rm_manageddisk

@nbr23
Copy link
Contributor Author

nbr23 commented Aug 27, 2021

Bundling d4004ed in as well, which leverages self.compute_models.OperatingSystemTypes(STR) to get the OperatingSystemTypes object instead of the dict base lookup.
Not a game changer but it homogenizes things, and future proofs (if another OS ends up being supported...)

Cheers!

@Fred-sun Fred-sun added medium_priority Medium priority ready_for_review The PR has been modified and can be reviewed and merged labels Aug 30, 2021
@xuzhang3
Copy link
Collaborator

LGTM

@xuzhang3 xuzhang3 merged commit 905eeb1 into ansible-collections:dev Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium_priority Medium priority ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants