bugfix for azure_rm_managementgroup_info module, subscriptions not detected as correct type #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fred-sun
reviewed
Sep 10, 2021
Fred-sun
reviewed
Sep 10, 2021
Fred-sun
added
medium_priority
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
|
Your suggestion was merged @Fred-sun , Thanks |
Fred-sun
added
ready_for_review
|
LGTM |
nbr23
pushed a commit
to nbr23/azure
that referenced
this pull request
Oct 26, 2021
…tected as correct type (ansible-collections#630) * updates ready for review * undisable the management group test * Update tests/integration/targets/azure_rm_managementgroup/aliases Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com> Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Bugfix for azure_rm_managementgroup_info . I am module's original author, and the detection for the object type has nonsense characters in it that were not caught. This fix will allow the module to correctly make the subscription dictionaries when that type is detected.
I've also updated the integration test to check for this kind of issue.
ISSUE TYPE
COMPONENT NAME
azure_rm_managementgroup_info
ADDITIONAL INFORMATION