Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new parameter enable_purge_protection to azure_rm_keyvault #643

Conversation

ghost
Copy link

@ghost ghost commented Sep 30, 2021

SUMMARY

Added support for enabling purge protection for keyvault.
Setting this property to true activates protection against purge for vault and its content. Default value of purge protection is set to false and once enabled, it can not be reverted i.e. Enabling this functionality is irreversible. This setting is effective only if soft delete is also enabled.

Fixes #629

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

azure_rm_keyvault
azure_rm_keyvault_info

@ghost
Copy link
Author

ghost commented Oct 1, 2021

@Fred-sun Can you help review this one as well? Thanks!

@Fred-sun
Copy link
Collaborator

Fred-sun commented Oct 7, 2021

@Fred-sun Can you help review this one as well? Thanks!

@techcon65 I'm working on it. Thank you very much!

@Fred-sun Fred-sun added new_feature New feature requirments ready_for_review The PR has been modified and can be reviewed and merged medium_priority Medium priority labels Oct 9, 2021
@xuzhang3
Copy link
Collaborator

LGTM

@xuzhang3 xuzhang3 merged commit fa38f94 into ansible-collections:dev Oct 14, 2021
@ghost ghost deleted the support-for-keyvault-purgeprotection branch October 14, 2021 07:33
nbr23 pushed a commit to nbr23/azure that referenced this pull request Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium_priority Medium priority new_feature New feature requirments ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing support for Key Vault Purge Protection
3 participants