Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnsibleTurboModule does transfer all AnsibleModule variable to the socket #65

Merged
merged 2 commits into from
Jun 29, 2021

Conversation

abikouo
Copy link
Contributor

@abikouo abikouo commented Jun 23, 2021

PASS_VARS is dict with each data item defined as a 2-tuple with first item corresponding to the attribute to the AnsibleModule class.

Consequently, only the check_mode was copied as this is the only variable with the same name on both the tuple and the PASS_VARS key.

@goneri
Copy link
Member

goneri commented Jun 23, 2021

Thank you @abikouo, may I ask you to add a changelog fragment with your PR?

@goneri goneri added the bug Something isn't working label Jun 23, 2021
@goneri goneri self-assigned this Jun 23, 2021
@goneri goneri added gate and removed gate labels Jun 24, 2021
@goneri
Copy link
Member

goneri commented Jun 24, 2021

Note: gating is failing because of https://review.opendev.org/c/zuul/zuul-jobs/+/797909

@goneri goneri closed this Jun 24, 2021
@goneri goneri reopened this Jun 24, 2021
@pabelanger
Copy link

recheck

1 similar comment
@pabelanger
Copy link

recheck

@goneri goneri added gate and removed gate labels Jun 24, 2021
@goneri goneri closed this Jun 24, 2021
@goneri goneri reopened this Jun 24, 2021
@goneri goneri added the gate label Jun 24, 2021
@ansible-zuul
Copy link

ansible-zuul bot commented Jun 24, 2021

Pull request merge failed: Required status check "ansible/check" is in progress.

@pabelanger
Copy link

recheck

@pabelanger
Copy link

This is a fall out of out gate requirement check now working properly after the upgrade. A recheck will fix it.

@pabelanger
Copy link

recheck

@pabelanger pabelanger closed this Jun 24, 2021
@pabelanger pabelanger reopened this Jun 24, 2021
@goneri goneri added gate and removed gate labels Jun 24, 2021
@pabelanger
Copy link

recheck

@pabelanger pabelanger added gate and removed gate labels Jun 25, 2021
@abikouo
Copy link
Contributor Author

abikouo commented Jun 25, 2021

recheck

@abikouo abikouo closed this Jun 25, 2021
@abikouo abikouo reopened this Jun 25, 2021
@abikouo abikouo added gate and removed gate labels Jun 29, 2021
@abikouo
Copy link
Contributor Author

abikouo commented Jun 29, 2021

recheck

@goneri goneri added gate and removed gate labels Jun 29, 2021
@ansible-zuul ansible-zuul bot merged commit 260078b into ansible-collections:main Jun 29, 2021
goneri added a commit to goneri/cloud.common that referenced this pull request Jul 29, 2021
Major Changes
-------------

- turbo - enable turbo mode for lookup plugins

Bugfixes
--------

- add exception handler to main async loop (ansible-collections#67).
- pass current task's environment through to execution (ansible-collections#69).
- turbo - AnsibleTurboModule was missing some _ansible_facts variable like _diff, _ansible_tmpdir. (ansible-collections#65)
- turbo - honor the ``remote_tmp`` configuration key.
@goneri goneri mentioned this pull request Jul 29, 2021
ansible-zuul bot pushed a commit that referenced this pull request Jul 29, 2021
prepare 2.0.4 release

Major Changes

turbo - enable turbo mode for lookup plugins

Bugfixes

add exception handler to main async loop (#67).
pass current task's environment through to execution (#69).
turbo - AnsibleTurboModule was missing some _ansible_facts variable like _diff, _ansible_tmpdir. (#65)
turbo - honor the remote_tmp configuration key.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants