Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s support diff mode #146

Merged
merged 13 commits into from
Jul 21, 2021
Merged

k8s support diff mode #146

merged 13 commits into from
Jul 21, 2021

Conversation

abikouo
Copy link
Contributor

@abikouo abikouo commented Jun 23, 2021

SUMMARY

diff attribute was always returned in output when k8s module was executed using options, force, apply or state=patched even if the diff=no was set at task level.
This fix aims to correct this
#88

This fix is not working if collection cloud.common is used without the fix ansible-collections/cloud.common#65

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

k8s

@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #146 (1d27c11) into main (a0a6d71) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #146   +/-   ##
=======================================
  Coverage   24.02%   24.02%           
=======================================
  Files           1        1           
  Lines         154      154           
  Branches       29       29           
=======================================
  Hits           37       37           
- Misses        111      112    +1     
+ Partials        6        5    -1     
Impacted Files Coverage Δ
...ections/kubernetes/core/plugins/action/k8s_info.py 24.02% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0a6d71...1d27c11. Read the comment docs.

@abikouo abikouo changed the title k8s support diff mode (breaking changes) k8s support diff mode Jun 24, 2021
Copy link
Member

@gravesm gravesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realized we also need to fix the k8s_scale and k8s_json_patch modules, too.

changelogs/fragments/146-k8s-add-support-diff-mode.yml Outdated Show resolved Hide resolved
Co-authored-by: Mike Graves <mgraves@redhat.com>
@abikouo abikouo requested a review from gravesm July 13, 2021 14:26
@gravesm
Copy link
Member

gravesm commented Jul 19, 2021

Just realized we also need to fix the k8s_scale and k8s_json_patch modules, too.

This still needs to be addressed.

@abikouo
Copy link
Contributor Author

abikouo commented Jul 20, 2021

Just realized we also need to fix the k8s_scale and k8s_json_patch modules, too.

This still needs to be addressed.

done

Copy link
Member

@gravesm gravesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants