aws_ssm: add profile support in connections

[amaxine]

SUMMARY

The aws_ssm connection type had no way of setting a profile except via environment variable. We have a specific need to set the profile name for this connection type, and this achieves that.

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

plugins/connection/aws_ssm.py

[felixfontein]

Cannot judge whether the changes to _get_boto_client are good, but the rest looks good!

[amaxine]

Added a minor fix to the integration test that should hopefully unbreak it - I was able to successfully run it with just that change. I did not enable the test because I'm not sure how this can account for the flakiness that was brought up in IRC.

[tremble]

@maxeaubrey,

I've applied this change over the top of #295 and I'm consistently getting an exception:

Traceback (most recent call last):
  File "/root/ansible_collections/community/aws/plugins/connection/aws_ssm.py", line 217, in wrapped
    return_tuple = func(self, *args, **kwargs)
  File "/root/ansible_collections/community/aws/plugins/connection/aws_ssm.py", line 356, in exec_command
    super(Connection, self).exec_command(cmd, in_data=in_data, sudoable=sudoable)
  File "/root/ansible/lib/ansible/plugins/connection/__init__.py", line 34, in wrapped
    self._connect()
  File "/root/ansible_collections/community/aws/plugins/connection/aws_ssm.py", line 291, in _connect
    self.start_session()
  File "/root/ansible_collections/community/aws/plugins/connection/aws_ssm.py", line 336, in start_session
    bufsize=0,
  File "/usr/lib/python3.6/subprocess.py", line 729, in __init__
    restore_signals, start_new_session)
  File "/usr/lib/python3.6/subprocess.py", line 1295, in _execute_child
    restore_signals, start_new_session, preexec_fn)
TypeError: expected str, bytes or os.PathLike object, not NoneType

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/root/ansible/lib/ansible/executor/task_executor.py", line 159, in run
    res = self._execute()
  File "/root/ansible/lib/ansible/executor/task_executor.py", line 574, in _execute
    result = self._handler.run(task_vars=variables)
  File "/root/ansible/lib/ansible/plugins/action/raw.py", line 42, in run
    result.update(self._low_level_execute_command(self._task.args.get('_raw_params'), executable=executable))
  File "/root/ansible/lib/ansible/plugins/action/__init__.py", line 1240, in _low_level_execute_command
    rc, stdout, stderr = self._connection.exec_command(cmd, in_data=in_data, sudoable=sudoable)
  File "/root/ansible_collections/community/aws/plugins/connection/aws_ssm.py", line 239, in wrapped
    self.close()
  File "/root/ansible_collections/community/aws/plugins/connection/aws_ssm.py", line 594, in close
    self._session.communicate(cmd)
AttributeError: 'NoneType' object has no attribute 'communicate'

I need to dig into this a little further to understand why, but it looks like something's not quite right with the change, possibly how it handles not being passed a profile (that's a wild guess).

[tremble]

I really appreciate you spending the time to track down the policy issue that was breaking the tests. For what it's worth, doing so appears to have uncovered a couple of small issues with the changes.

[goneri]

Hi @maxeaubrey,

Can you please rebase your PR, this way we will be able to continue this review. Thank you for your contribution.

[amaxine]

Thanks, I've rebased - though admittedly I did not retest this myself as I won't be able to until Monday 😅

[alinabuzachis]

Hi @maxeaubrey, thank you for your contribution. There was one was task failing due to timeout, so I will rerun the CI. May I ask you to add a changeling fragment https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs?

[amaxine]

@alinabuzachis Happily! Pushed a commit for it, hope it's good.

[dekimsey]

Could this be better set as an entry on the configuration blob above?
Perhaps with AWS_PROFILE support too?

profile:
   ...
   default: ''
   env:
    - name: AWS_PROFILE

[tremble]

Tested locally

[tremble]

LGTM

[tremble]

Hi @maxeaubrey,

sorry it's taken so long to get this merged. The feature should be available once v1.5.0 of this collection is released (probably sometime this month)

[tremble]

Thanks for your contribution

[amaxine]

@tremble Awesome! Thanks for helping me get this into a mergeable state!