Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rds_cluster_snapshot - new module to handle RDS cluster snapshotting #788

Conversation

alinabuzachis
Copy link
Contributor

@alinabuzachis alinabuzachis commented Nov 1, 2021

SUMMARY

rds_cluster_snapshot - new module to handle RDS cluster snapshotting

Requires rds_cluster to be merged first #687

Depends-On: ansible-collections/amazon.aws#840
Requires: mattclay/aws-terminator#212

Requires also mattclay/aws-terminator#184

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

rds_cluster_snapshot

@ansibullbot
Copy link

@softwarefactory-project-zuul
Copy link
Contributor

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

@jillr
Copy link
Collaborator

jillr commented Jan 14, 2022

recheck

@marknet15
Copy link
Contributor

recheck

@alinabuzachis
Copy link
Contributor Author

recheck

@alinabuzachis
Copy link
Contributor Author

recheck

@alinabuzachis
Copy link
Contributor Author

Ah, completely forgot. will need to merge #687 first. Not sure if we can include these two in this release at this point.

@markuman markuman added the backport-3 PR should be backported to the stable-3 branch label Mar 25, 2022
@ansibullbot ansibullbot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Jun 1, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

ansible-galaxy-importer FAILURE in 4m 03s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 42s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 40s (non-voting)
ansible-test-sanity-docker-milestone TIMED_OUT in 1h 00m 58s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 11m 25s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 51s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 36s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 47s
✔️ ansible-test-splitter SUCCESS in 2m 41s
integration-community.aws-1 FAILURE in 19m 07s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@gravesm
Copy link
Member

gravesm commented Jun 1, 2022

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

ansible-galaxy-importer FAILURE in 4m 57s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 52s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 53s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 41s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 14m 01s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 53s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 08s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 15s
✔️ ansible-test-splitter SUCCESS in 2m 35s
integration-community.aws-1 RETRY_LIMIT in 1m 35s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@alinabuzachis
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

ansible-galaxy-importer FAILURE in 4m 22s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 52s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 13s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 09s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 12m 43s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 11m 49s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 01s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 04s
✔️ ansible-test-splitter SUCCESS in 2m 50s
✔️ integration-community.aws-1 SUCCESS in 14m 54s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@ansibullbot ansibullbot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Jun 1, 2022
Copy link
Contributor

@jatorcasso jatorcasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jatorcasso
Copy link
Contributor

Oops I approved twice :)

softwarefactory-project-zuul bot pushed a commit to ansible-collections/amazon.aws that referenced this pull request Jun 7, 2022
Add support for copy_db_cluster_snapshot for rds_cluster_snapshot

SUMMARY

Add support for copy_db_cluster_snapshot for rds_cluster_snapshot

Necessary for ansible-collections/community.aws#788
Just to verify:
Depends-On: ansible/ansible-zuul-jobs#1520
ISSUE TYPE


Feature Pull Request

COMPONENT NAME

module_utils/rds.py
ADDITIONAL INFORMATION

Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Jill R <None>
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like although you've added the retry decorator, nothing's actually using aws_retry=True, so the decorator won't be used...

Thought for 5.0.0, should we change the default for aws_retry to True?

plugins/modules/rds_cluster_snapshot.py Show resolved Hide resolved
plugins/modules/rds_cluster_snapshot.py Outdated Show resolved Hide resolved
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
@alinabuzachis
Copy link
Contributor Author

Looks like although you've added the retry decorator, nothing's actually using aws_retry=True, so the decorator won't be used...

Thought for 5.0.0, should we change the default for aws_retry to True?

I guess that would be awesome!

@ansibullbot ansibullbot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Jun 14, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

ansible-galaxy-importer FAILURE in 5m 31s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 55s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 57s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 34s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 13m 19s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 12m 39s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 24s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 36s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 5m 42s
✔️ ansible-test-splitter SUCCESS in 2m 27s
✔️ integration-community.aws-1 SUCCESS in 12m 32s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@ansibullbot ansibullbot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Jun 14, 2022
@ansibullbot ansibullbot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Jun 14, 2022
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jun 14, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

ansible-galaxy-importer FAILURE in 4m 15s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 52s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 29s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 34s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 38s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 8m 57s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 16s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 5m 40s
✔️ ansible-test-splitter SUCCESS in 2m 22s
✔️ integration-community.aws-1 SUCCESS in 13m 48s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 5e7acbd into ansible-collections:main Jun 14, 2022
@patchback
Copy link

patchback bot commented Jun 14, 2022

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/5e7acbd2f92b718c058c13ccc0999d6567fedf5c/pr-788

Backported as #1238

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jun 14, 2022
…788)

rds_cluster_snapshot -  new module to handle RDS cluster snapshotting

SUMMARY

rds_cluster_snapshot -  new module to handle RDS cluster snapshotting
Requires rds_cluster to be merged first #687
Depends-On: ansible-collections/amazon.aws#840
Requires: mattclay/aws-terminator#212
Requires also mattclay/aws-terminator#184

ISSUE TYPE

New Module Pull Request

COMPONENT NAME

rds_cluster_snapshot

Reviewed-by: Markus Bergholz <git@osuv.de>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mark Chappell <None>
Reviewed-by: Joseph Torcasso <None>
(cherry picked from commit 5e7acbd)
jatorcasso pushed a commit to jatorcasso/amazon.aws that referenced this pull request Jun 27, 2022
…sible-collections#840)

Add support for copy_db_cluster_snapshot for rds_cluster_snapshot

SUMMARY

Add support for copy_db_cluster_snapshot for rds_cluster_snapshot

Necessary for ansible-collections/community.aws#788
Just to verify:
Depends-On: ansible/ansible-zuul-jobs#1520
ISSUE TYPE


Feature Pull Request

COMPONENT NAME

module_utils/rds.py
ADDITIONAL INFORMATION

Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Jill R <None>
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…nsible-collections#788)

rds_cluster_snapshot -  new module to handle RDS cluster snapshotting

SUMMARY

rds_cluster_snapshot -  new module to handle RDS cluster snapshotting
Requires rds_cluster to be merged first ansible-collections#687
Depends-On: ansible-collections/amazon.aws#840
Requires: mattclay/aws-terminator#212
Requires also mattclay/aws-terminator#184

ISSUE TYPE

New Module Pull Request

COMPONENT NAME

rds_cluster_snapshot

Reviewed-by: Markus Bergholz <git@osuv.de>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mark Chappell <None>
Reviewed-by: Joseph Torcasso <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@5e7acbd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3 PR should be backported to the stable-3 branch integration tests/integration merge_commit This PR contains at least one merge commit. Please resolve! mergeit Merge the PR (SoftwareFactory) module module needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html new_module New module new_plugin New plugin plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants