Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add py3.9 test jobs #1520

Merged

Conversation

alinabuzachis
Copy link
Collaborator

No description provided.

@softwarefactory-project-zuul
Copy link
Contributor

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

---
- hosts: all
tasks:
- name: Ensure python3.9 is present (Debian/Ubuntu)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have any Ubuntu left. You can just keep the second task.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Removed.

zuul.d/jobs.yaml Outdated
- job:
name: ansible-test-units-base-python39
parent: ansible-test-units-base
nodeset: controller-python39
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just use the fedora-35-1vcpu nodeset.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

@@ -625,6 +625,16 @@
nodes:
- fedora-35

- nodeset:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer we don't had yet another controller-pythonXY node. This is a bit pointless since they all point on Fedora 35 BTW :-).

@@ -280,7 +280,7 @@
- job:
name: ansible-test-cloud-integration-aws
parent: ansible-core-ci-aws-session
nodeset: controller-python38
nodeset: controller-python39
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same, you can just use fedora-35-1vcpu.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

@@ -337,6 +337,12 @@
- name: controller
label: ansible-fedora-35-1vcpu

- nodeset:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same, you can remove this entry. BTW the file doesn't exist anymore \o/.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed!

@softwarefactory-project-zuul
Copy link
Contributor

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/ansible/ansible-zuul-jobs for 1520,e1f7e21dc5727e7069c8eedcaf4645d66279546e

@alinabuzachis alinabuzachis requested a review from goneri May 5, 2022 12:01
@alinabuzachis alinabuzachis changed the title WIP: Add py3.9 test jobs Add py3.9 test jobs May 13, 2022
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
@softwarefactory-project-zuul
Copy link
Contributor

Zuul encountered a syntax error while parsing its configuration in the
repo ansible/ansible-zuul-jobs on branch master. The error was:

Job ansible-test-cloud-integration-vmware-rest-python38 not defined

The error appears in the following project-template stanza:

project-template:
name: ansible-collections-cloud-common
check:
jobs: &ansible-collections-cloud-common-jobs
- ansible-test-sanity-docker-devel
- ansible-test-sanity-docker-milestone
- ansible-test-cloud-integration-vmware-rest-python38:
required-projects:
- name: github.com/ansible-collections/vmware.vmware_rest
- build-ansible-collection:
required-projects:
- name: github.com/ansible-collections/community.vmware
- name: github.com/ansible-collections/vmware.vmware_rest
- name: github.com/ansible-collections/kubernetes.core
- ansible-test-splitter:
required-projects:
- name: github.com/ansible-collections/kubernetes.core
vars:
ansible_test_splitter__test_changed: false
ansible_test_splitter__total_job: 3
ansible_test_splitter__check_for_changes_in:
- "~/{{ zuul.projects['github.com/ansible-collections/kubernetes.core'].src_dir }}"
ansible_test_splitter__releases_to_test:
- "with-turbo"
- integration-kubernetes.core-with-turbo-1
- integration-kubernetes.core-with-turbo-2
- integration-kubernetes.core-with-turbo-3
gate:
jobs: *ansible-collections-cloud-common-jobs
periodic:
jobs:
- ansible-test-sanity-docker-devel
- ansible-test-sanity-docker-milestone
- build-ansible-collection

in "ansible/ansible-zuul-jobs/zuul.d/project-templates.yaml@master", line 586, column 3

Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
@alinabuzachis
Copy link
Collaborator Author

Zuul encountered a syntax error while parsing its configuration in the repo ansible/ansible-zuul-jobs on branch master. The error was:

Job ansible-test-cloud-integration-vmware-rest-python38 not defined

The error appears in the following project-template stanza:

project-template: name: ansible-collections-cloud-common check: jobs: &ansible-collections-cloud-common-jobs - ansible-test-sanity-docker-devel - ansible-test-sanity-docker-milestone - ansible-test-cloud-integration-vmware-rest-python38: required-projects: - name: github.com/ansible-collections/vmware.vmware_rest - build-ansible-collection: required-projects: - name: github.com/ansible-collections/community.vmware - name: github.com/ansible-collections/vmware.vmware_rest - name: github.com/ansible-collections/kubernetes.core - ansible-test-splitter: required-projects: - name: github.com/ansible-collections/kubernetes.core vars: ansible_test_splitter__test_changed: false ansible_test_splitter__total_job: 3 ansible_test_splitter__check_for_changes_in: - "~/{{ zuul.projects['github.com/ansible-collections/kubernetes.core'].src_dir }}" ansible_test_splitter__releases_to_test: - "with-turbo" - integration-kubernetes.core-with-turbo-1 - integration-kubernetes.core-with-turbo-2 - integration-kubernetes.core-with-turbo-3 gate: jobs: *ansible-collections-cloud-common-jobs periodic: jobs: - ansible-test-sanity-docker-devel - ansible-test-sanity-docker-milestone - build-ansible-collection

in "ansible/ansible-zuul-jobs/zuul.d/project-templates.yaml@master", line 586, column 3

@goneri This job was missing. Not sure if you want to keep it as ansible-test-cloud-integration-vmware-rest or ansible-test-cloud-integration-vmware-rest-python39? It seems ansible-test-cloud-integration-vmware-rest uses already python 3.9 (if I am not mistaken).

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-tox-linters SUCCESS in 4m 58s
✔️ ansible-tox-py38 SUCCESS in 6m 08s
✔️ ansible-tox-py39 SUCCESS in 4m 36s
✔️ ansible-tox-py310 SUCCESS in 5m 10s

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-tox-linters SUCCESS in 5m 33s
✔️ ansible-tox-py38 SUCCESS in 4m 57s
✔️ ansible-tox-py39 SUCCESS in 4m 53s
✔️ ansible-tox-py310 SUCCESS in 5m 16s

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-tox-linters SUCCESS in 4m 39s
✔️ ansible-tox-py38 SUCCESS in 4m 45s
✔️ ansible-tox-py39 SUCCESS in 5m 12s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 9fb8ec1 into ansible:master Jun 2, 2022
softwarefactory-project-zuul bot pushed a commit to ansible-collections/amazon.aws that referenced this pull request Jun 7, 2022
Add support for copy_db_cluster_snapshot for rds_cluster_snapshot

SUMMARY

Add support for copy_db_cluster_snapshot for rds_cluster_snapshot

Necessary for ansible-collections/community.aws#788
Just to verify:
Depends-On: ansible/ansible-zuul-jobs#1520
ISSUE TYPE


Feature Pull Request

COMPONENT NAME

module_utils/rds.py
ADDITIONAL INFORMATION

Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Jill R <None>
jatorcasso pushed a commit to jatorcasso/amazon.aws that referenced this pull request Jun 27, 2022
…sible-collections#840)

Add support for copy_db_cluster_snapshot for rds_cluster_snapshot

SUMMARY

Add support for copy_db_cluster_snapshot for rds_cluster_snapshot

Necessary for ansible-collections/community.aws#788
Just to verify:
Depends-On: ansible/ansible-zuul-jobs#1520
ISSUE TYPE


Feature Pull Request

COMPONENT NAME

module_utils/rds.py
ADDITIONAL INFORMATION

Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Jill R <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Merge the PR (SoftwareFActory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants