Update rds_instance_snaphot to use handlers defined in rds.py #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alinabuzachis
changed the title
…s and enable check_mode Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
alinabuzachis
force-pushed
the
rds_instance_snapshot
branch
from
fbccb45
to
85949c9
Compare
ansibullbot
added
community_review
feature
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
|
recheck |
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
|
Build failed.
|
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
alinabuzachis
force-pushed
the
rds_instance_snapshot
branch
from
2f27c7d
to
372c067
Compare
|
recheck |
|
recheck |
|
Build failed.
|
|
recheck |
|
recheck |
|
recheck |
|
Build succeeded.
|
marknet15
approved these changes
Jan 28, 2022
tremble
reviewed
Apr 14, 2022
alinabuzachis
force-pushed
the
rds_instance_snapshot
branch
from
75801b8
to
f4e36ba
Compare
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
alinabuzachis
force-pushed
the
rds_instance_snapshot
branch
from
f4e36ba
to
65ebdce
Compare
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
|
recheck |
markuman
approved these changes
May 6, 2022
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #1139 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
May 9, 2022
Update rds_instance_snaphot to use handlers defined in rds.py SUMMARY Update module to use handlers defined in rds.py Enable check_mode Add integration tests Depends-On: ansible-collections/amazon.aws#553 Also requires: mattclay/aws-terminator#185 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance_snapshot Reviewed-by: Jill R <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Mark Chappell <None> Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Joseph Torcasso <None> (cherry picked from commit 872f6e3)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
May 9, 2022
…1139) [PR #789/872f6e31 backport][stable-3] Update rds_instance_snaphot to use handlers defined in rds.py This is a backport of PR #789 as merged into main (872f6e3). SUMMARY Update module to use handlers defined in rds.py Enable check_mode Add integration tests Depends-On: ansible-collections/amazon.aws#553 Also requires: mattclay/aws-terminator#185 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance_snapshot Reviewed-by: Alina Buzachis <None>
1 task
1 task
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…e-collections#789) Update rds_instance_snaphot to use handlers defined in rds.py SUMMARY Update module to use handlers defined in rds.py Enable check_mode Add integration tests Depends-On: ansible-collections/amazon.aws#553 Also requires: mattclay/aws-terminator#185 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance_snapshot Reviewed-by: Jill R <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Mark Chappell <None> Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Joseph Torcasso <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@872f6e3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Depends-On: ansible-collections/amazon.aws#553
Also requires: mattclay/aws-terminator#185
ISSUE TYPE
COMPONENT NAME
rds_instance_snapshot