Improve error handling rds.py for RDS cluster and snapshot #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
WIP
|
recheck |
alinabuzachis
force-pushed
the
module_utils/rds.py-update-cluster
branch
from
bacb6ea
to
c0bf581
Compare
tremble
reviewed
Oct 29, 2021
|
recheck |
1 similar comment
|
recheck |
alinabuzachis
changed the title
jillr
reviewed
Nov 12, 2021
| @@ -181,20 +230,43 @@ def wait_for_cluster_status(client, module, db_cluster_id, waiter_name): | |||
| module.fail_json_aws(e, msg="Failed with an unexpected error while waiting for the DB cluster {0}".format(db_cluster_id)) | |||
|
|
|||
|
|
|||
| def wait_for_snapshot_status(client, module, db_snapshot_id, waiter_name): | |||
There was a problem hiding this comment.
Could you please create a new unit test file for this module_util and cover this new function? Eventually we should try to cover the rest of the util but it's a lot easier to ask for folks to contribute tests for changes if the test file already exists.
We should also run the integration tests for the RDS modules with a depends-on for this change, to ensure there's no regressions.
There was a problem hiding this comment.
@jillr Done that!
|
recheck |
2 similar comments
|
recheck |
|
recheck |
alinabuzachis
changed the title
|
recheck |
2 similar comments
|
recheck |
|
recheck |
|
recheck |
1 similar comment
|
recheck |
|
cc @goneri |
softwarefactory-project-zuul bot
pushed a commit
to ansible-collections/community.aws
that referenced
this pull request
May 9, 2022
…1139) [PR #789/872f6e31 backport][stable-3] Update rds_instance_snaphot to use handlers defined in rds.py This is a backport of PR #789 as merged into main (872f6e3). SUMMARY Update module to use handlers defined in rds.py Enable check_mode Add integration tests Depends-On: ansible-collections/amazon.aws#553 Also requires: mattclay/aws-terminator#185 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance_snapshot Reviewed-by: Alina Buzachis <None>
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 9, 2022
…e-collections#789) Update rds_instance_snaphot to use handlers defined in rds.py SUMMARY Update module to use handlers defined in rds.py Enable check_mode Add integration tests Depends-On: ansible-collections#553 Also requires: mattclay/aws-terminator#185 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance_snapshot Reviewed-by: Jill R <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Mark Chappell <None> Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Joseph Torcasso <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@872f6e3
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 9, 2022
…e-collections#789) Update rds_instance_snaphot to use handlers defined in rds.py SUMMARY Update module to use handlers defined in rds.py Enable check_mode Add integration tests Depends-On: ansible-collections#553 Also requires: mattclay/aws-terminator#185 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance_snapshot Reviewed-by: Jill R <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Mark Chappell <None> Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Joseph Torcasso <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@872f6e3
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 9, 2022
New modules for RDS clusters management SUMMARY Two new modules for RDS clusters management (rds_cluster ans rds_cluster_info) Took over from: ansible-collections#262 Depends-On: ansible-collections#553 Closes ansible-collections#849 Should also close ansible-collections#191 ISSUE TYPE New Module Pull Request Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@3661b1c
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 9, 2022
…e-collections#789) Update rds_instance_snaphot to use handlers defined in rds.py SUMMARY Update module to use handlers defined in rds.py Enable check_mode Add integration tests Depends-On: ansible-collections#553 Also requires: mattclay/aws-terminator#185 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance_snapshot Reviewed-by: Jill R <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Mark Chappell <None> Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Joseph Torcasso <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@872f6e3
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 9, 2022
New modules for RDS clusters management SUMMARY Two new modules for RDS clusters management (rds_cluster ans rds_cluster_info) Took over from: ansible-collections#262 Depends-On: ansible-collections#553 Closes ansible-collections#849 Should also close ansible-collections#191 ISSUE TYPE New Module Pull Request Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@3661b1c
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 9, 2022
…e-collections#789) Update rds_instance_snaphot to use handlers defined in rds.py SUMMARY Update module to use handlers defined in rds.py Enable check_mode Add integration tests Depends-On: ansible-collections#553 Also requires: mattclay/aws-terminator#185 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance_snapshot Reviewed-by: Jill R <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Mark Chappell <None> Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Joseph Torcasso <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@872f6e3
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 16, 2022
New modules for RDS clusters management SUMMARY Two new modules for RDS clusters management (rds_cluster ans rds_cluster_info) Took over from: ansible-collections#262 Depends-On: ansible-collections#553 Closes ansible-collections#849 Should also close ansible-collections#191 ISSUE TYPE New Module Pull Request Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@3661b1c
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 16, 2022
…e-collections#789) Update rds_instance_snaphot to use handlers defined in rds.py SUMMARY Update module to use handlers defined in rds.py Enable check_mode Add integration tests Depends-On: ansible-collections#553 Also requires: mattclay/aws-terminator#185 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance_snapshot Reviewed-by: Jill R <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Mark Chappell <None> Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Joseph Torcasso <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@872f6e3
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
New modules for RDS clusters management SUMMARY Two new modules for RDS clusters management (rds_cluster ans rds_cluster_info) Took over from: ansible-collections#262 Depends-On: ansible-collections#553 Closes ansible-collections#849 Should also close ansible-collections#191 ISSUE TYPE New Module Pull Request Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@3661b1c
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
…e-collections#789) Update rds_instance_snaphot to use handlers defined in rds.py SUMMARY Update module to use handlers defined in rds.py Enable check_mode Add integration tests Depends-On: ansible-collections#553 Also requires: mattclay/aws-terminator#185 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance_snapshot Reviewed-by: Jill R <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Mark Chappell <None> Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Joseph Torcasso <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@872f6e3
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
New modules for RDS clusters management SUMMARY Two new modules for RDS clusters management (rds_cluster ans rds_cluster_info) Took over from: ansible-collections#262 Depends-On: ansible-collections#553 Closes ansible-collections#849 Should also close ansible-collections#191 ISSUE TYPE New Module Pull Request Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@3661b1c
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
…e-collections#789) Update rds_instance_snaphot to use handlers defined in rds.py SUMMARY Update module to use handlers defined in rds.py Enable check_mode Add integration tests Depends-On: ansible-collections#553 Also requires: mattclay/aws-terminator#185 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance_snapshot Reviewed-by: Jill R <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Mark Chappell <None> Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Joseph Torcasso <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@872f6e3
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
New modules for RDS clusters management SUMMARY Two new modules for RDS clusters management (rds_cluster ans rds_cluster_info) Took over from: ansible-collections#262 Depends-On: ansible-collections#553 Closes ansible-collections#849 Should also close ansible-collections#191 ISSUE TYPE New Module Pull Request Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@3661b1c
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
New modules for RDS clusters management SUMMARY Two new modules for RDS clusters management (rds_cluster ans rds_cluster_info) Took over from: ansible-collections#262 Depends-On: ansible-collections#553 Closes ansible-collections#849 Should also close ansible-collections#191 ISSUE TYPE New Module Pull Request Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@3661b1c
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
…e-collections#789) Update rds_instance_snaphot to use handlers defined in rds.py SUMMARY Update module to use handlers defined in rds.py Enable check_mode Add integration tests Depends-On: ansible-collections#553 Also requires: mattclay/aws-terminator#185 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance_snapshot Reviewed-by: Jill R <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Mark Chappell <None> Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Joseph Torcasso <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@872f6e3
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
New modules for RDS clusters management SUMMARY Two new modules for RDS clusters management (rds_cluster ans rds_cluster_info) Took over from: ansible-collections#262 Depends-On: ansible-collections#553 Closes ansible-collections#849 Should also close ansible-collections#191 ISSUE TYPE New Module Pull Request Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@3661b1c
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
…e-collections#789) Update rds_instance_snaphot to use handlers defined in rds.py SUMMARY Update module to use handlers defined in rds.py Enable check_mode Add integration tests Depends-On: ansible-collections#553 Also requires: mattclay/aws-terminator#185 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance_snapshot Reviewed-by: Jill R <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Mark Chappell <None> Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Joseph Torcasso <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@872f6e3
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
…e-collections#789) Update rds_instance_snaphot to use handlers defined in rds.py SUMMARY Update module to use handlers defined in rds.py Enable check_mode Add integration tests Depends-On: ansible-collections#553 Also requires: mattclay/aws-terminator#185 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance_snapshot Reviewed-by: Jill R <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Mark Chappell <None> Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Joseph Torcasso <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@872f6e3
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
…e-collections#789) Update rds_instance_snaphot to use handlers defined in rds.py SUMMARY Update module to use handlers defined in rds.py Enable check_mode Add integration tests Depends-On: ansible-collections#553 Also requires: mattclay/aws-terminator#185 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance_snapshot Reviewed-by: Jill R <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Mark Chappell <None> Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Joseph Torcasso <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@872f6e3
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 22, 2022
rds_subnet_group: Add tags feature and enable check_mode SUMMARY rds_subnet_group: Add tags feature and enable check_mode Fixes: ansible-collections#552 Depends-On: ansible-collections#553 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_subnet_group Reviewed-by: Jill R <None> Reviewed-by: Mark Chappell <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Markus Bergholz <git@osuv.de> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@ce599bd
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 23, 2022
rds_subnet_group: Add tags feature and enable check_mode SUMMARY rds_subnet_group: Add tags feature and enable check_mode Fixes: ansible-collections#552 Depends-On: ansible-collections#553 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_subnet_group Reviewed-by: Jill R <None> Reviewed-by: Mark Chappell <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Markus Bergholz <git@osuv.de> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@ce599bd
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 23, 2022
rds_subnet_group: Add tags feature and enable check_mode SUMMARY rds_subnet_group: Add tags feature and enable check_mode Fixes: ansible-collections#552 Depends-On: ansible-collections#553 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_subnet_group Reviewed-by: Jill R <None> Reviewed-by: Mark Chappell <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Markus Bergholz <git@osuv.de> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@ce599bd
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
rds_subnet_group: Add tags feature and enable check_mode SUMMARY rds_subnet_group: Add tags feature and enable check_mode Fixes: ansible-collections#552 Depends-On: ansible-collections#553 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_subnet_group Reviewed-by: Jill R <None> Reviewed-by: Mark Chappell <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Markus Bergholz <git@osuv.de>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
New modules for RDS clusters management SUMMARY Two new modules for RDS clusters management (rds_cluster ans rds_cluster_info) Took over from: ansible-collections#262 Depends-On: ansible-collections#553 Closes ansible-collections#849 Should also close ansible-collections#191 ISSUE TYPE New Module Pull Request Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…e-collections#789) Update rds_instance_snaphot to use handlers defined in rds.py SUMMARY Update module to use handlers defined in rds.py Enable check_mode Add integration tests Depends-On: ansible-collections#553 Also requires: mattclay/aws-terminator#185 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance_snapshot Reviewed-by: Jill R <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Mark Chappell <None> Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Joseph Torcasso <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
rds_subnet_group: Add tags feature and enable check_mode SUMMARY rds_subnet_group: Add tags feature and enable check_mode Fixes: ansible-collections#552 Depends-On: ansible-collections#553 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_subnet_group Reviewed-by: Jill R <None> Reviewed-by: Mark Chappell <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Markus Bergholz <git@osuv.de>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
New modules for RDS clusters management SUMMARY Two new modules for RDS clusters management (rds_cluster ans rds_cluster_info) Took over from: ansible-collections#262 Depends-On: ansible-collections#553 Closes ansible-collections#849 Should also close ansible-collections#191 ISSUE TYPE New Module Pull Request Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…e-collections#789) Update rds_instance_snaphot to use handlers defined in rds.py SUMMARY Update module to use handlers defined in rds.py Enable check_mode Add integration tests Depends-On: ansible-collections#553 Also requires: mattclay/aws-terminator#185 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance_snapshot Reviewed-by: Jill R <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Mark Chappell <None> Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Joseph Torcasso <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…_aggregator/fix_organization_source
Fix KeyError in aws_config_aggregator module
Reviewed-by: Ansibullbot manages ticket workflow
https://github.com/ansibullbot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
rds_clusterrds_instance_snapshotandrds_cluster_snapshotISSUE TYPE
COMPONENT NAME
module_utils/rds.py