homebrew: Honor update_homebrew value (#112)

Added environment variable to honor update_homebrew argument specified by user. Fixes: ansible/ansible#56650 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
ansible-collections · Apr 5, 2020 · 645fe91 · 645fe91
1 parent e338938
commit 645fe91
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 8 deletions.
diff --git a/changelogs/fragments/56650-homebrew-update_brew.yml b/changelogs/fragments/56650-homebrew-update_brew.yml
@@ -0,0 +1,2 @@
+minor_changes:
+- homebrew - Added environment variable to honor update_homebrew setting (https://github.com/ansible/ansible/issues/56650).
diff --git a/plugins/modules/packaging/os/homebrew.py b/plugins/modules/packaging/os/homebrew.py
@@ -941,6 +941,10 @@ def main():
         state = 'absent'
 
     update_homebrew = p['update_homebrew']
+    if not update_homebrew:
+        module.run_command_environ_update.update(
+            dict(HOMEBREW_NO_AUTO_UPDATE="True")
+        )
     upgrade_all = p['upgrade_all']
     p['install_options'] = p['install_options'] or []
     install_options = ['--{0}'.format(install_option)

diff --git a/tests/integration/targets/homebrew/tasks/main.yml b/tests/integration/targets/homebrew/tasks/main.yml
@@ -35,8 +35,6 @@
   become: yes
   become_user: "{{ brew_stat.stat.pw_name }}"
   register: xz_result
-  environment:
-    HOMEBREW_NO_AUTO_UPDATE: True
 
 - assert:
     that:
@@ -50,8 +48,6 @@
   become: yes
   become_user: "{{ brew_stat.stat.pw_name }}"
   register: xz_result
-  environment:
-    HOMEBREW_NO_AUTO_UPDATE: True
 
 - assert:
     that:
@@ -65,8 +61,6 @@
   become: yes
   become_user: "{{ brew_stat.stat.pw_name }}"
   register: xz_result
-  environment:
-    HOMEBREW_NO_AUTO_UPDATE: True
 
 - assert:
     that:
@@ -80,8 +74,6 @@
   become: yes
   become_user: "{{ brew_stat.stat.pw_name }}"
   register: xz_result
-  environment:
-    HOMEBREW_NO_AUTO_UPDATE: True
 
 - assert:
     that: