New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
homebrew: Add support for services functions #8286
Comments
Files identified in the description: If these files are incorrect, please update the |
I'm not a homebrew user, but having a separate module is usually a better idea. Otherwise you eventually end up with 'monsters' such as docker_image, which has way too many options for way too many different operations. That makes the module's code pretty complex, and the module's documentation more confusing (you see a looong list of options and have to figure out which ones are actually relevant for your use-case). |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
!component =plugins/modules/homebrew.py |
Files identified in the description: If these files are incorrect, please update the |
Yup, sounds good to me. Hopefully be back within the week with a PR |
Fixes ansible-collections#8286. Add a homebrew.services module for starting and stopping services that are attached to homebrew packages.
Fixes ansible-collections#8286. Add a homebrew.services module for starting and stopping services that are attached to homebrew packages.
Fixes ansible-collections#8286. Add a homebrew.services module for starting and stopping services that are attached to homebrew packages.
Summary
I'd like to add support for things like:
More than happy to implement it myself. But I am looking for some advice from the maintainers.
Issue Type
Feature Idea
Component Name
homebrew
Additional Information
Specifically, should I follow the current pattern of the
update
function and add a service parameter to the current homebrew module? Or should I add a newhomebrew_services
module?I personally feel like a new module makes the most sense. Here are my current thoughts on the two choices:
Add a
service
parametername:
andservice:
to both be defined. And while the order of operations is obvious (install before service), that all needs to be defined and maintained.Add a
homebrew_services
moduleCode of Conduct
The text was updated successfully, but these errors were encountered: