Change Proxmox agent argument to string.
#5107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
reitermarkus
changed the title
agent argument to string.agent argument to string.
This comment was marked as outdated.
This comment was marked as outdated.
reitermarkus
force-pushed
the
proxmox-agent
branch
from
d9f6a93
to
b5c84cb
Compare
ansibullbot
added
ci_verified
reitermarkus
force-pushed
the
proxmox-agent
branch
2 times, most recently
from
6094b48
to
f7214c9
Compare
ansibullbot
removed
ci_verified
reitermarkus
commented
Aug 11, 2022
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
felixfontein
added
check-before-release
reitermarkus
force-pushed
the
proxmox-agent
branch
from
f7214c9
to
f38de1b
Compare
reitermarkus
force-pushed
the
proxmox-agent
branch
from
f38de1b
to
f486472
Compare
felixfontein
approved these changes
Aug 13, 2022
|
If nobody from the maintainers complains, I'll merge somewhen this weekend. |
This was referenced Nov 20, 2022
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 1, 2022
1 task
1 task
|
Hi, this change actually breaks the proxmox_kvm module. (#5360) |
|
@fritterhoff that's rather old news, since that bug was fixed pretty shortly after this got merged (in #5198). Or do you still have this (exact) problem with the latest release? |
|
Nvm. Error seems to be fixed. Sorry :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Allow specifying Proxmox
agentargument as string.ISSUE TYPE
COMPONENT NAME
proxmox_kvmADDITIONAL INFORMATION
The
agentargument can not only betrueorfalse(or0/1) but also be a string, e.g.enabled=1,fstrim_cloned_disks=1.Extracted from #4027.