Send string instead of boolean to proxmox api #5198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
There was a problem hiding this comment.
I don't think this is necessary, since the bug you are probably experiencing was already fixed in #5194.
If that is not fixing the bug for you, then I don't think the parameter ever worked for you before.
felixfontein
added
check-before-release
1 task
Co-authored-by: castorsky <csky57@gmail.com>
felixfontein
approved these changes
Oct 23, 2022
ansibullbot
added
has_issue
and removed
small_patch
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
ansibullbot
added
the
needs_revision
|
CI failures are unrelated. |
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #5417 🤖 @patchback |
felixfontein
removed
the
check-before-release
patchback bot
pushed a commit
that referenced
this pull request
Oct 23, 2022
* Send string instead of boolean to proxmox api * Add changelog fragment. * Update plugins/modules/cloud/misc/proxmox_kvm.py Co-authored-by: castorsky <csky57@gmail.com> Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: castorsky <csky57@gmail.com> (cherry picked from commit b9d0864)
|
@alxhlz thanks for your contribution! |
felixfontein
pushed a commit
that referenced
this pull request
Oct 23, 2022
* Send string instead of boolean to proxmox api * Add changelog fragment. * Update plugins/modules/cloud/misc/proxmox_kvm.py Co-authored-by: castorsky <csky57@gmail.com> Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: castorsky <csky57@gmail.com> (cherry picked from commit b9d0864) Co-authored-by: Alexander Holzapfel <git@hlz.io>
russoz
pushed a commit
to russoz-ansible/community.general
that referenced
this pull request
Nov 5, 2022
* Send string instead of boolean to proxmox api * Add changelog fragment. * Update plugins/modules/cloud/misc/proxmox_kvm.py Co-authored-by: castorsky <csky57@gmail.com> Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: castorsky <csky57@gmail.com>
This was referenced Nov 20, 2022
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 1, 2022
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
In this commit the parameter sent to proxmox api has been changed from type bool to type string but instead of converting the boolean into a value that is readable by the proxmox api it just sends a string containing
'True'or'False'to the pve api. According to specification proxmox expects a'1'or a'0'as content of theagentparameter.This bug resulted in failing vm creations:
ISSUE TYPE
COMPONENT NAME
proxmox_kvm