Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR #5198/b9d08649 backport][stable-5] Send string instead of boolean to proxmox api #5417

Merged
merged 1 commit into from Oct 23, 2022
Merged

[PR #5198/b9d08649 backport][stable-5] Send string instead of boolean to proxmox api #5417

merged 1 commit into from Oct 23, 2022

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Oct 23, 2022

This is a backport of PR #5198 as merged into main (b9d0864).

SUMMARY

In this commit the parameter sent to proxmox api has been changed from type bool to type string but instead of converting the boolean into a value that is readable by the proxmox api it just sends a string containing 'True' or 'False' to the pve api. According to specification proxmox expects a '1' or a '0' as content of the agent parameter.

This bug resulted in failing vm creations:

fatal: [vm-template -> localhost]: FAILED! => {"changed": false, "msg": "creation of qemu VM test with vmid 171 failed with exception=400 Bad Request: Parameter verification failed. - {'agent': \"invalid format - format error\\nagent.enabled: type check ('boolean') failed - got 'True'\\n\"}", "vmid": "171"}
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

proxmox_kvm

@alxhlz @patchback
Send string instead of boolean to proxmox api (#5198)
2ae481b 
* Send string instead of boolean to proxmox api

* Add changelog fragment.

* Update plugins/modules/cloud/misc/proxmox_kvm.py

Co-authored-by: castorsky <csky57@gmail.com>

Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: castorsky <csky57@gmail.com>
(cherry picked from commit b9d0864)
@patchback patchback bot mentioned this pull request Oct 23, 2022
Merged
@ansibullbot
Copy link
Collaborator

cc @Ajpantuso @Thulium-Drake @helldorado @joshainglis @karmab @tleguern
click here for bot help

@ansibullbot ansibullbot added backport bug This issue/PR relates to a bug cloud module module new_contributor Help guide this first time contributor plugins plugin (any type) needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Oct 23, 2022
@felixfontein
Copy link
Collaborator

I'm giving up on CI. Since the original PR passed the important parts, and stable-5 is very close to main, I'm going to ignore the CI failures.

@felixfontein felixfontein merged commit f75471e into stable-5 Oct 23, 2022
@felixfontein felixfontein deleted the patchback/backports/stable-5/b9d08649578e8a5838e532cd5f04e0ee031e13e1/pr-5198 branch October 23, 2022 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug This issue/PR relates to a bug cloud module module needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ansibullbot @felixfontein @alxhlz