-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rundeck - fix TypeError on 404 api response #6983
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
changelogs/fragments/6983-rundeck-fix-typerrror-on-404-api-response.yml
Outdated
Show resolved
Hide resolved
…ponse.yml Co-authored-by: Felix Fontein <felix@fontein.de>
If nobody objects, I'll merge this by the end of this week. |
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #7040 🤖 @patchback |
* fix TypeError on 404 api response * add changelog fragment * Update changelogs/fragments/6983-rundeck-fix-typerrror-on-404-api-response.yml Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Vincent CHARLES <vincent.charles@swatchgroup.com> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit a942545)
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #7041 🤖 @patchback |
@MehuiSeklayr thanks for your contribution! |
* fix TypeError on 404 api response * add changelog fragment * Update changelogs/fragments/6983-rundeck-fix-typerrror-on-404-api-response.yml Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Vincent CHARLES <vincent.charles@swatchgroup.com> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit a942545)
… api response (#7041) Rundeck - fix TypeError on 404 api response (#6983) * fix TypeError on 404 api response * add changelog fragment * Update changelogs/fragments/6983-rundeck-fix-typerrror-on-404-api-response.yml Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Vincent CHARLES <vincent.charles@swatchgroup.com> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit a942545) Co-authored-by: Vincent CHARLES <124702855+MehuiSeklayr@users.noreply.github.com>
… api response (#7040) Rundeck - fix TypeError on 404 api response (#6983) * fix TypeError on 404 api response * add changelog fragment * Update changelogs/fragments/6983-rundeck-fix-typerrror-on-404-api-response.yml Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Vincent CHARLES <vincent.charles@swatchgroup.com> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit a942545) Co-authored-by: Vincent CHARLES <124702855+MehuiSeklayr@users.noreply.github.com>
Hello dear Ansible community :)
This is my first contribution, feel free to express any kind of criticism, be it on the content or the format.
SUMMARY
I found a bug when using
community.general.rundeck_acl_policy
.While creating a new ACL, I was greeted by the following trace:
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
On success, the
fetch_url
function returns something like:<addinfourl at 139713744344848 whose fp = <socket._fileobject object at 0x7f11a69761d0>>
However, when the api returns a 404, the return value is:
HTTP Error 404: Not Found
In such a case,
response.read()
fails with the aforementionned TypeError.The error could be specific to sundeck's API version. I did my testing with api version 40, which is not too far behind latest (v45), and way ahead of the current depreciation threshold (v14). source
Let me know if I am missing anything!
Have a great day :)