[PR #6983/a942545d backport][stable-7] Rundeck - fix TypeError on 404 api response

[patchback]

This is a backport of PR #6983 as merged into main (a942545).

Hello dear Ansible community :)

This is my first contribution, feel free to express any kind of criticism, be it on the content or the format.

SUMMARY

I found a bug when using community.general.rundeck_acl_policy.

While creating a new ACL, I was greeted by the following trace:

  File "/.../community/general/plugins/modules/rundeck_acl_policy.py", line 239, in <module>
  File "/.../community/general/plugins/modules/rundeck_acl_policy.py", line 233, in main
  File "/.../community/general/plugins/modules/rundeck_acl_policy.py", line 143, in create_or_update_acl
  File "/.../community/general/plugins/modules/rundeck_acl_policy.py", line 137, in get_acl
  File "/.../community/general/plugins/module_utils/rundeck.py", line 83, in api_request
TypeError: 'NoneType' object is not callable

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

• plugins/module_utils/rundeck.py

ADDITIONAL INFORMATION

On success, the fetch_url function returns something like:
<addinfourl at 139713744344848 whose fp = <socket._fileobject object at 0x7f11a69761d0>>

However, when the api returns a 404, the return value is:
HTTP Error 404: Not Found
In such a case, response.read() fails with the aforementionned TypeError.

The error could be specific to sundeck's API version. I did my testing with api version 40, which is not too far behind latest (v45), and way ahead of the current depreciation threshold (v14). source

Let me know if I am missing anything!

Have a great day :)