Added OpenNebula inventory plugin #810

feldsam · 2020-08-20T21:29:23Z

SUMMARY

Added new inventory plugin for use with OpenNebula based clouds

ISSUE TYPE

New Plugin Pull Request

COMPONENT NAME

opennebula inventory plugin

REFS ansible/ansible#66394

Andersson007

@feldsam thanks for the PR!
In additional to added, all new stuff should have ci or unit tests

plugins/inventory/opennebula.py

Andersson007 · 2020-10-21T10:56:49Z

cc @ilicmilan @meerkampdvv @rvalle @rsmontero @xorel

plugins/inventory/opennebula.py

Andersson007 · 2020-10-28T06:48:12Z

looks like unit tests (with pytest) is all that we need

feldsam · 2020-10-28T06:53:27Z

Hello, I never do it, would you point me to some example? Thanks

Andersson007 · 2020-10-28T07:04:37Z

Hi, sure, there are a lot of examples living in tests/units/ subdirectories including tests for plugins
The aim is to cover your code as full as possible (maybe split it to more functions would be required). It'll help be sure the covered things work as expected and will protect the plugin if anybody accidentally breaks something when fixing a bug or adding features.
Some old of them use unittest but Ansible documentation says to use pytest. If any questions, feel free to ask.

felixfontein · 2020-10-28T07:16:12Z

As concrete examples for inventory plugins, see https://github.com/ansible-collections/community.general/blob/main/tests/unit/plugins/inventory/test_proxmox.py and https://github.com/ansible-collections/community.general/blob/main/tests/unit/plugins/inventory/test_stackpath_compute.py. These were added recently (and you can see that one of them was inspired by the other :) ).

feldsam · 2020-10-28T07:29:04Z

Thank you guys, I look into it in one-two weeks.

felixfontein · 2021-02-26T09:06:20Z

@feldsam are you still working on this?

needs_info

feldsam · 2021-03-03T15:28:20Z

@felixfontein Hi, I am just asked community to help write tests for this plugin.

Signed-off-by: Kristian Feldsam <feldsam@gmail.com>

feldsam · 2021-09-27T21:56:07Z

Hi @felixfontein I just added unit tests

felixfontein

Just two things that need to be updated, I think then this is ready for merging!

plugins/inventory/opennebula.py

Co-authored-by: Felix Fontein <felix@fontein.de>

feldsam · 2021-09-28T06:55:29Z

@felixfontein done

russoz

LGTM! Thanks @feldsam !!

patchback · 2021-09-28T14:32:29Z

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/806f1ea3c99a5b77791d0a5afc5680f69549e001/pr-810

Backported as #3460

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

* Added OpenNebula inventory plugin Signed-off-by: Kristián Feldsam <feldsam@gmail.com> * Apply suggestions from code review Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru> * Apply suggestions from code review Co-authored-by: Felix Fontein <felix@fontein.de> * Removed matching inventory yaml files ending with "one" Too general word * Apply suggestions from code review Co-authored-by: Felix Fontein <felix@fontein.de> * Apply suggestions from code review Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com> Signed-off-by: Kristian Feldsam <feldsam@gmail.com> * Added BOTMETA Signed-off-by: Kristian Feldsam <feldsam@gmail.com> * Moved import Signed-off-by: Kristian Feldsam <feldsam@gmail.com> * Fix indentation problem Signed-off-by: Kristian Feldsam <feldsam@gmail.com> * Added group_by_labels, refactored so can be unit tested Signed-off-by: Kristian Feldsam <feldsam@gmail.com> * Added unit tests Signed-off-by: Kristian Feldsam <feldsam@gmail.com> * Removed blank line Signed-off-by: Kristian Feldsam <feldsam@gmail.com> * Apply suggestions from code review Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru> Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com> (cherry picked from commit 806f1ea)

felixfontein · 2021-09-28T14:33:13Z

@feldsam thanks for contributing this!
@Andersson007 @russoz thanks for reviewing!

* Added OpenNebula inventory plugin Signed-off-by: Kristián Feldsam <feldsam@gmail.com> * Apply suggestions from code review Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru> * Apply suggestions from code review Co-authored-by: Felix Fontein <felix@fontein.de> * Removed matching inventory yaml files ending with "one" Too general word * Apply suggestions from code review Co-authored-by: Felix Fontein <felix@fontein.de> * Apply suggestions from code review Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com> Signed-off-by: Kristian Feldsam <feldsam@gmail.com> * Added BOTMETA Signed-off-by: Kristian Feldsam <feldsam@gmail.com> * Moved import Signed-off-by: Kristian Feldsam <feldsam@gmail.com> * Fix indentation problem Signed-off-by: Kristian Feldsam <feldsam@gmail.com> * Added group_by_labels, refactored so can be unit tested Signed-off-by: Kristian Feldsam <feldsam@gmail.com> * Added unit tests Signed-off-by: Kristian Feldsam <feldsam@gmail.com> * Removed blank line Signed-off-by: Kristian Feldsam <feldsam@gmail.com> * Apply suggestions from code review Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru> Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com> (cherry picked from commit 806f1ea) Co-authored-by: Kristian Feldsam <feldsam@gmail.com>

ansibullbot added affects_2.10 community_review inventory inventory plugin needs_triage new_contributor Help guide this first time contributor new_plugin New plugin plugins plugin (any type) labels Aug 20, 2020

feldsam force-pushed the inventory-opennebula branch 2 times, most recently from c3298be to 6adaf5b Compare August 20, 2020 21:41

This comment has been minimized.

Sign in to view

ansibullbot added ci_verified Push fixes to PR branch to re-run CI stale_ci CI is older than 7 days, rerun before merging labels Oct 21, 2020

Andersson007 reviewed Oct 21, 2020

View reviewed changes

ansibullbot removed ci_verified Push fixes to PR branch to re-run CI stale_ci CI is older than 7 days, rerun before merging labels Oct 21, 2020

felixfontein reviewed Oct 21, 2020

View reviewed changes

felixfontein reviewed Oct 22, 2020

View reviewed changes

ansibullbot added needs_info This issue requires further information. Please answer any outstanding questions stale_ci CI is older than 7 days, rerun before merging and removed community_review labels Feb 26, 2021

ansibullbot added community_review and removed needs_info This issue requires further information. Please answer any outstanding questions labels Mar 3, 2021

feldsam added 2 commits September 27, 2021 23:14

Added group_by_labels, refactored so can be unit tested

593343b

Signed-off-by: Kristian Feldsam <feldsam@gmail.com>

Added unit tests

6e03bc5

Signed-off-by: Kristian Feldsam <feldsam@gmail.com>

feldsam force-pushed the inventory-opennebula branch from c286223 to 6e03bc5 Compare September 27, 2021 21:16

ansibullbot added tests tests unit tests/unit labels Sep 27, 2021

This comment has been minimized.

Sign in to view

ansibullbot added ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Sep 27, 2021

Removed blank line

2768bbd

Signed-off-by: Kristian Feldsam <feldsam@gmail.com>

ansibullbot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Sep 27, 2021

ansibullbot removed the needs_info This issue requires further information. Please answer any outstanding questions label Sep 27, 2021

felixfontein removed the waiting_on_contributor Needs help. Feel free to engage to get things unblocked label Sep 28, 2021

ansibullbot added the waiting_on_contributor Needs help. Feel free to engage to get things unblocked label Sep 28, 2021

felixfontein reviewed Sep 28, 2021

View reviewed changes

plugins/inventory/opennebula.py Outdated Show resolved Hide resolved

plugins/inventory/opennebula.py Outdated Show resolved Hide resolved

felixfontein added the check-before-release PR will be looked at again shortly before release and merged if possible. label Sep 28, 2021

Apply suggestions from code review

0931a82

Co-authored-by: Felix Fontein <felix@fontein.de>

russoz approved these changes Sep 28, 2021

View reviewed changes

ansibullbot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Sep 28, 2021

felixfontein merged commit 806f1ea into ansible-collections:main Sep 28, 2021

felixfontein added the backport-3 label Sep 28, 2021

felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Sep 28, 2021

patchback bot mentioned this pull request Sep 28, 2021

[PR #810/806f1ea3 backport][stable-3] Added OpenNebula inventory plugin #3460

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added OpenNebula inventory plugin #810

Added OpenNebula inventory plugin #810

feldsam commented Aug 20, 2020 •

edited

Loading

This comment has been minimized.

Andersson007 left a comment

Andersson007 commented Oct 21, 2020

Andersson007 commented Oct 28, 2020

feldsam commented Oct 28, 2020

Andersson007 commented Oct 28, 2020 •

edited

Loading

felixfontein commented Oct 28, 2020

feldsam commented Oct 28, 2020

felixfontein commented Feb 26, 2021

feldsam commented Mar 3, 2021

This comment has been minimized.

feldsam commented Sep 27, 2021

felixfontein left a comment

feldsam commented Sep 28, 2021

russoz left a comment

patchback bot commented Sep 28, 2021 •

edited

Loading

felixfontein commented Sep 28, 2021

Added OpenNebula inventory plugin #810

Added OpenNebula inventory plugin #810

Conversation

feldsam commented Aug 20, 2020 • edited Loading

SUMMARY

ISSUE TYPE

COMPONENT NAME

This comment has been minimized.

Andersson007 left a comment

Choose a reason for hiding this comment

Andersson007 commented Oct 21, 2020

Andersson007 commented Oct 28, 2020

feldsam commented Oct 28, 2020

Andersson007 commented Oct 28, 2020 • edited Loading

felixfontein commented Oct 28, 2020

feldsam commented Oct 28, 2020

felixfontein commented Feb 26, 2021

feldsam commented Mar 3, 2021

This comment has been minimized.

feldsam commented Sep 27, 2021

felixfontein left a comment

Choose a reason for hiding this comment

feldsam commented Sep 28, 2021

russoz left a comment

Choose a reason for hiding this comment

patchback bot commented Sep 28, 2021 • edited Loading

Backport to stable-3: 💚 backport PR created

felixfontein commented Sep 28, 2021

feldsam commented Aug 20, 2020 •

edited

Loading

Andersson007 commented Oct 28, 2020 •

edited

Loading

patchback bot commented Sep 28, 2021 •

edited

Loading