Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing codecov flag file association for auth_cert #188

Merged
merged 1 commit into from
Nov 6, 2021

Conversation

briantist
Copy link
Collaborator

@briantist briantist commented Nov 6, 2021

SUMMARY

Addendum to #159

Adds the codecov mapping for cert auth.

This probably will not show up in coverage on the PR; I think the XML is only used from the default branch. it actually did work!

ISSUE TYPE
  • CI/coverage Pull Request
COMPONENT NAME

CI/coverage

ADDITIONAL INFORMATION

N/A

@briantist briantist added the ci Specifically related to the CI on this repo label Nov 6, 2021
@briantist briantist self-assigned this Nov 6, 2021
@briantist briantist temporarily deployed to docs-build November 6, 2021 19:25 Inactive
@codecov
Copy link

codecov bot commented Nov 6, 2021

Codecov Report

Merging #188 (43cb532) into main (261f7b1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #188   +/-   ##
=======================================
  Coverage   91.69%   91.69%           
=======================================
  Files          40       40           
  Lines        1589     1589           
  Branches      122      122           
=======================================
  Hits         1457     1457           
  Misses        119      119           
  Partials       13       13           
Flag Coverage Δ
env_docker-default 91.69% <ø> (ø)
integration 75.59% <ø> (ø)
sanity 37.65% <ø> (ø)
target_ansible-doc 100.00% <ø> (ø)
target_auth_approle 89.47% <ø> (ø)
target_auth_cert 86.36% <ø> (+30.15%) ⬆️
target_auth_jwt 91.30% <ø> (ø)
target_auth_none 100.00% <ø> (ø)
target_auth_token 71.42% <ø> (ø)
target_connection_options 74.76% <ø> (ø)
target_controller 66.62% <ø> (ø)
target_import 37.65% <ø> (ø)
target_lookup_hashi_vault 81.33% <ø> (ø)
target_lookup_vault_read 90.00% <ø> (ø)
target_module_utils 90.17% <ø> (ø)
target_module_vault_read 92.10% <ø> (ø)
units 88.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 261f7b1...43cb532. Read the comment docs.

@briantist briantist merged commit 13e3caf into ansible-collections:main Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Specifically related to the CI on this repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant