Add open_url test framework #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #24 +/- ##
===========================================
+ Coverage 55.91% 72.05% +16.14%
===========================================
Files 6 9 +3
Lines 279 476 +197
Branches 33 55 +22
===========================================
+ Hits 156 343 +187
- Misses 113 117 +4
- Partials 10 16 +6
Continue to review full report at Codecov.
|
felixfontein
added a commit
to felixfontein/community.hrobot
that referenced
this pull request
Dec 7, 2020
felixfontein
changed the title
felixfontein
added a commit
to ansible-collections/community.hrobot
that referenced
this pull request
Dec 11, 2020
* Move generic open_url code for plugins to module_utils. * Move failover code from module_utils/robot to module_utils/failover. * Add boilerplate. * Add tests for plugin_open_url_json. * Make it work with all Python versions. * Use community.internal_test_tools from ansible-collections/community.internal_test_tools#24 * Fix error instantiation. * Add more complete test. * The branch has been merged, but the collection hasn't been released yet. * Forgot to remove path to my repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Analogue to the fetch_url module test framework.
ISSUE TYPE
COMPONENT NAME
tests/unit/utils/open_url_framework.py