Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

helm: handle multiline output #400

Closed
wants to merge 1 commit into from

Conversation

Akasurde
Copy link
Member

SUMMARY

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/modules/helm.py
plugins/modules/helm_plugin_info.py

@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #400 (6259635) into main (c9157ce) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #400   +/-   ##
=======================================
  Coverage   23.17%   23.17%           
=======================================
  Files           1        1           
  Lines         151      151           
  Branches       24       24           
=======================================
  Hits           35       35           
  Misses        111      111           
  Partials        5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9157ce...6259635. Read the comment docs.

@Akasurde Akasurde force-pushed the i399 branch 2 times, most recently from 366f16b to 14c891c Compare March 29, 2021 14:56
We parse ``helm plugin list`` output. Parsing logic fails if
plugin provides multiline description.

* added fix for parsing plugin multiline description
* test added for this change

Fixes: #399

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@Akasurde Akasurde changed the title [WIP] helm: handle multiline output helm: handle multiline output Mar 29, 2021
@gravesm
Copy link
Member

gravesm commented Apr 14, 2021

@Akasurde could you re-open this in kubernetes.core? Also, would be good to address @abikouo's comment, then we can get this merged.

@Akasurde
Copy link
Member Author

superseded by ansible-collections/kubernetes.core#64

@Akasurde Akasurde closed this Apr 16, 2021
@Akasurde Akasurde deleted the i399 branch April 16, 2021 13:20
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

This repository does not accept pull requests, see the README for details.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants