Add broker_state option to rabbitmq_plugin. #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shadow6363
force-pushed
the
add_offline_plugin_option
branch
from
d71b07a
to
acf18b0
Compare
Shadow6363
force-pushed
the
add_offline_plugin_option
branch
from
2e93fe9
to
7945429
Compare
|
I think the only tests that failed are from network problems, but I don't have permission to retry tests. |
odyssey4me
requested changes
Jun 30, 2020
|
All tests worked and passed this time. Thanks again for the prompt review! |
odyssey4me
approved these changes
Jul 1, 2020
ChandlerSwift
pushed a commit
to ChandlerSwift/community.rabbitmq
that referenced
this pull request
Dec 22, 2020
Add broker_state option to rabbitmq_plugin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adds a
broker_stateoption torabbitmq_pluginthat controls whether or not an attempt is made to connect to the node to change the plugin state.Some plugins require the plugin enabled state to be modified directly, without connecting to the node first.
An example of this is AWS Peer Discovery Plugin.
I wasn't sure what to call the option so if you have better suggestions, please let me know.
ISSUE TYPE
COMPONENT NAME
rabbitmq_pluginADDITIONAL INFORMATION
Further information on the option can be found in the official RabbitMQ documentation on the command.