vmware_host_snmp: Add code to support SNMP values

[tejaswi-bachu]

Depends-On: #1102

SUMMARY

Added code to support setting SNMP syscontact and syslocation.

Fixes #1044

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

vmware_host_snmp.py
community.vmware.vmware_host_snmp_module.rst

ADDITIONAL INFORMATION

[mariolenz]

Could you please add a changelog fragment? Something like changelogs/fragments/1044-vmware_host_snmp.yml:

minor_changes:
  - vmware_host_snmp - implement setting syscontact and syslocation (https://github.com/ansible-collections/community.vmware/issues/1044).

And I think this might be worth a test case in tests/integration/targets/vmware_host_snmp/tasks/main.yml. Do you think you can do this? It should be mostly copy&paste, add setting syscontact / syslocation and assert that you get a change.

[mariolenz]

I'm not sure if a recheck would take into account the Depends-On: #1102 that I've added. So I'll try to close and re-open this PR.

[goneri]

@mariolenz when you set a Depends-On:, you need to use the full path, e.g: https://github.com/ansible-collections/community.vmware/pull/1102, instead of #1102.

[mariolenz]

when you set a Depends-On:, you need to use the full path, e.g: https://github.com/ansible-collections/community.vmware/pull/1102, instead of #1102.

Sorry, I knew this but I tend to forget it. Maybe because

Depends-On: https://github.com/ansible-collections/community.vmware/pull/1102

looks exactly like

Depends-On: #1102

:-/

[goneri]

:-/

No worry :-). I know it's confusing.

[tejaswi-bachu]

@mariolenz @Akasurde - Thanks for your feedback. I made the required changes. Please review.

[mariolenz]

LGTM!

What do you say @Akasurde?

[ansible-zuul]

LGTM!

done

[Akasurde]

recheck

[goneri]

recheck

[mariolenz]

The duplicate version_added in lines 80 / 81 and 86 / 87 are a problem for our sanity checks.

[mariolenz]

recheck

[mariolenz]

LGTM