Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for SNMP syslocation and syscontact configuration #1044

Closed
JayBeeCee opened this issue Sep 21, 2021 · 5 comments · Fixed by #1103
Closed

Adding support for SNMP syslocation and syscontact configuration #1044

JayBeeCee opened this issue Sep 21, 2021 · 5 comments · Fixed by #1103
Labels
feature This issue/PR relates to a feature request has_pr needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly
Milestone
v.1.17.0

Comments

@JayBeeCee
Copy link

SUMMARY

Add support for SNMP syscontact and syslocation configuration

ISSUE TYPE
  • Module improvement
COMPONENT NAME

community.vmware.vmware_host_snmp

ADDITIONAL INFORMATION

Currently it is not possible to configure SNMP syscontact and syslocation via mentioned module. The module should provide parameters to do so.

- name: Enable and configure SNMP
  community.vmware.vmware_host_snmp:
    hostname: '{{ esxi_host }}'
    username: '{{ esxi_user }}'
    password: '{{ esxi_host_pass }}'
    snmp_port: '{{ esxi_snmp_port }}'
    community: [ '{{ esxi_snmp_community }}' ]
    contact: '{{ esxi_snmp_contact }}'
    location: '{{ esxi_snmp_location }}'
    state: enabled
  delegate_to: localhost
@ansibullbot
Copy link

Files identified in the description:
None

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibullbot
Copy link

@JayBeeCee: Greetings! Thanks for taking the time to open this issue. In order for the community to handle your issue effectively, we need a bit more information.

Here are the items we could not find in your description:

  • ansible version

Please set the description of this issue with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/ISSUE_TEMPLATE/bug_report.md

click here for bot help

@ansibullbot ansibullbot added needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly needs_triage Needs a first human triage before being processed. labels Sep 21, 2021
@Akasurde Akasurde added feature This issue/PR relates to a feature request waiting_on_contributor Needs help. Feel free to engage to get things unblocked and removed needs_triage Needs a first human triage before being processed. labels Sep 27, 2021
@tejaswi-bachu
Copy link
Contributor

@Akasurde & @JayBeeCee - I've submitted a pull request - 1103 to support this feature. Please verify.

@mariolenz
Copy link
Collaborator

I've submitted a pull request - 1103 to support this feature. Please verify.

If you add a '#', like #1103, you'll automatically get a link to your PR ;-)

This isn't really necessary, but makes it a bit easier to navigate to the PR from here.

@mariolenz mariolenz mentioned this issue Nov 10, 2021
Merged
@mariolenz mariolenz removed needs_info This issue requires further information. Please answer any outstanding questions waiting_on_contributor Needs help. Feel free to engage to get things unblocked labels Nov 10, 2021
@Akasurde
Copy link
Member

resolved_by_pr #1103

@Akasurde Akasurde added this to the v.1.17.0 milestone Nov 11, 2021
ansible-zuul bot pushed a commit that referenced this issue Nov 17, 2021
@tejaswi-bachu
vmware_host_snmp: Add code to support SNMP values (#1103)
3061ee7 
vmware_host_snmp: Add code to support SNMP values

Depends-On: #1102
SUMMARY
Added code to support setting SNMP syscontact and syslocation.
Fixes #1044
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
vmware_host_snmp.py
community.vmware.vmware_host_snmp_module.rst
ADDITIONAL INFORMATION

Reviewed-by: Mario Lenz <m@riolenz.de>
Reviewed-by: Abhijeet Kasurde <None>
Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net>
Reviewed-by: None <None>
Reviewed-by: Tejaswi Bachu <teja.bachu@gmail.com>
This was referenced Mar 2, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request has_pr needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly
Projects
None yet
Milestone
v.1.17.0
Development

Successfully merging a pull request may close this issue.

vmware_host_snmp: Add code to support SNMP values tejaswi-bachu/community.vmware
5 participants
@Akasurde @mariolenz @tejaswi-bachu @JayBeeCee @ansibullbot